Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ID-377 Add pact contract provider tests. #60

Merged
merged 15 commits into from
May 25, 2023
Merged

ID-377 Add pact contract provider tests. #60

merged 15 commits into from
May 25, 2023

Conversation

Ghost-in-a-Jar
Copy link
Contributor

@Ghost-in-a-Jar Ghost-in-a-Jar commented May 18, 2023 •
edited
Loading

Added a verification test suite and github action, otherwise just refactoring.

@Ghost-in-a-Jar Ghost-in-a-Jar force-pushed the ID-377-add-provider-tests branch from 32cbfb2 to f50b0de Compare May 18, 2023 17:33
@ichengchang ichengchang mentioned this pull request May 19, 2023
Merged
Shakespeared
Shakespeared approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@Shakespeared Shakespeared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ghost-in-a-Jar Ghost-in-a-Jar force-pushed the ID-377-add-provider-tests branch from 3dfbd5d to 53c076b Compare May 23, 2023 18:24
@Ghost-in-a-Jar Ghost-in-a-Jar force-pushed the ID-377-add-provider-tests branch from 3276f3c to cb0ba01 Compare May 24, 2023 19:36
@Ghost-in-a-Jar Ghost-in-a-Jar force-pushed the ID-377-add-provider-tests branch from 287e501 to 5c6a78f Compare May 24, 2023 19:45
@Ghost-in-a-Jar Ghost-in-a-Jar force-pushed the ID-377-add-provider-tests branch 4 times, most recently from 6188faf to 70a426f Compare May 24, 2023 20:37
@Ghost-in-a-Jar Ghost-in-a-Jar force-pushed the ID-377-add-provider-tests branch from 70a426f to 26b1daf Compare May 24, 2023 20:48
@codecov
Copy link

codecov bot commented May 25, 2023 •
edited
Loading

Codecov Report

Merging #60 (fbe78c1) into dev (f7791fb) will increase coverage by 0.08%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                dev      #60      +/-   ##
============================================
+ Coverage     81.46%   81.55%   +0.08%     
  Complexity      182      182              
============================================
  Files            30       30              
  Lines           615      618       +3     
  Branches         64       64              
============================================
+ Hits            501      504       +3     
  Misses           84       84              
  Partials         30       30
Impacted Files Coverage Δ
.../bio/terra/drshub/config/DrsProviderInterface.java 90.00% <100.00%> (+1.11%) ⬆️
.../src/main/java/bio/terra/drshub/models/Fields.java 96.29% <100.00%> (ø)

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Ghost-in-a-Jar Ghost-in-a-Jar merged commit b218ae7 into dev May 25, 2023
@Ghost-in-a-Jar Ghost-in-a-Jar deleted the ID-377-add-provider-tests branch May 25, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlangs tlangs tlangs approved these changes

@Shakespeared Shakespeared Shakespeared approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ghost-in-a-Jar @tlangs @Shakespeared