ID-377 Add drshub consumer test url resolution #7142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ghost-in-a-Jar
commented
May 18, 2023
| repo: broadinstitute/terra-github-workflows | ||
| ref: refs/heads/main | ||
| token: ${{ secrets.BROADBOT_TOKEN }} # github token for access to kick off a job in the private repo | ||
| inputs: '{ "pacticipant": "cromwell-consumer", "version": "${{ needs.init-github-context.outputs.repo-version }}" }' |
There was a problem hiding this comment.
This is all copied straight from leo's workflows with 'leo' -> 'cromwell'
Ghost-in-a-Jar
force-pushed
the
ID-377-add-drshub-consumer-test-url-resolution
branch
from
d1ce835 to
54d5fe2
Compare
ichengchang
reviewed
May 19, 2023
|
|
||
| can-i-deploy: | ||
| runs-on: ubuntu-latest | ||
| if: ${{ needs.init-github-context.outputs.fork == 'false' }} |
There was a problem hiding this comment.
You can disable can-i-deploy and publish the cromwell contract to pact broker if you like. Later, when your drshub provider test in this PR is done you can add a webhook (essentially just like https://github.com/broadinstitute/sam/blob/develop/.github/workflows/verify_consumer_pacts.yml and you can reenable can-i-deploy again. This is just a suggestion.
Suggested change
| if: ${{ needs.init-github-context.outputs.fork == 'false' }} | |
| if: ${{ needs.init-github-context.outputs.fork == 'false' && false }} |
There was a problem hiding this comment.
That sounds good thanks
THWiseman
approved these changes
May 22, 2023
Ghost-in-a-Jar
force-pushed
the
ID-377-add-drshub-consumer-test-url-resolution
branch
from
54d5fe2 to
476aaff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added pact github actions workflows from leo.
Added consumer test for drshub url resolution.