Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lets update the documentation for navbar search. #1746

Closed
wants to merge 2 commits into from

Conversation

drainx
Copy link
Contributor

@drainx drainx commented Jul 16, 2015

How about a fix for #1669 . Just because it works in master doesn't mean the docs shouldn't be updated. It in fact does not work as intended in master, which was the whole point of that issue in the first place.

Signed-off-by: Daniel Rix Drainx1@live.com

Signed-off-by: Daniel Rix <Drainx1@live.com>
Signed-off-by: Daniel Rix <Drainx1@live.com>
@Dogfalo
Copy link
Owner

Dogfalo commented Jul 17, 2015

You are using the wrong icon files

@Dogfalo Dogfalo closed this Jul 17, 2015
@drainx
Copy link
Contributor Author

drainx commented Jul 17, 2015

Please elaborate.
It is clearly broken as pointed out in #1669, and this is the appropriate fix for it, again as stated in #1669 ; another maintainer even states that the docs haven't been updated.

@carlosperate
Copy link

You are pulling in the use of the old icons. The google material icons should be used instead: http://materializecss.com/icons.html

@drainx
Copy link
Contributor Author

drainx commented Jul 17, 2015

So then why is it broken on the main site, which is using that icon family?
For reference, this image: http://puu.sh/j2WSM/77d5d8fae5.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants