[HOLD for payment 2023-03-20] Emoji reactions while hovering use the wrong copy and icon

[stitesExpensify]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Hover a message
2. Hover over the "add emoji reaction" button

Expected Result:

1. The icon should have a + in the smile
2. The tooltip should have the same copy as

Actual Result:

1. The icon has no plus
2. The tooltip is different

Workaround:

Just use it still

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number:
Reproducible in staging?: YES
Reproducible in production?: NO
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @daraksha-dk
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1678364126072099

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010dc226c476fee5c5
• Upwork Job ID: 1633938437672779776
• Last Price Increase: 2023-03-09

[MelvinBot]

Triggered auto assignment to @tjferriss (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[stitesExpensify]

I'll be taking this on internally FYI

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~010dc226c476fee5c5

[MelvinBot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @parasharrajat (Internal)

[stitesExpensify]

@parasharrajat removing you because we don't need a C+ on this one. We just need the upwork job to pay @daraksha-dk the finders fee

[tjferriss]

@daraksha-dk please apply to the Upworks job for the reporting bonus: https://www.upwork.com/jobs/~010dc226c476fee5c5

[daraksha-dk]

@tjferriss the job seems to be private

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix emoji reaction icon and copy #15792

If no regressions arise, payment will be issued on 2023-03-20. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@stitesExpensify] The PR that introduced the bug has been identified. Link to the PR:
• [@stitesExpensify] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@stitesExpensify] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@tjferriss] Determine if we should create a regression test for the bug.
• [@stitesExpensify] If we decide to create a regression test for the bug, please propose the regression test steps to the appropriate location to ensure the same bug will not reach production again.
• [@tjferriss] Review the proposed regression test steps and location.
• [@tjferriss] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[MelvinBot]

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

[tjferriss]

Whoops, I've made it public. Can you try again? https://www.upwork.com/jobs/~010dc226c476fee5c5

[tjferriss]

@stitesExpensify do you think we need a regression test for this? If so, can you provide the steps?

[daraksha-dk]

@tjferriss Thanks, I've applied now

[parasharrajat]

@tjferriss this job is supposed to be priced at 250. I think you have mistakenly set it to 1000.

[tjferriss]

Correct, my mistake. @daraksha-dk you have a pending offer for the $250.

[tjferriss]

@daraksha-dk payment has been made in UpWorks.

@stitesExpensify bump on this comment. I think we do want to add a regression test. If you agree, can you outline the steps?

[stitesExpensify]

Sorry I was OOO. I don't think we need a regression, this was a one off mistake. The copy and icon will likely never change again