Update Pay an Invoice and Send an Invoice FAQ section so it collapses #49135

Christinadobrzyn · 2024-09-12T19:19:59Z

Details

Updating the FAQ section to remove this dupe mention

Also making the Send an Invoice FAQ section collapsable

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

trying to remove the duplicate FAQ section from the side bar

Updating the FAQ section so it collapses

melvin-bot · 2024-09-12T19:20:28Z

@mjasikowski Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

OSBotify · 2024-09-12T19:22:55Z

A preview of your ExpensifyHelp changes have been deployed to https://head.helpdot.pages.dev ⚡️

Creating a new webpage for workflows

blimpich · 2024-09-12T22:20:57Z

@Christinadobrzyn can you confirm that your changes worked as expected in the test deploy? #49135 (comment)

Reviewed without checklist, my bad

mjasikowski

Just one small change, but it would be also great if you could directly link to the slack or GitHub discussion relevant to the issue in the description, so we can see the context.

mjasikowski · 2024-09-13T07:37:08Z

docs/articles/new-expensify/expenses-&-payments/Send-an-invoice.md

@@ -62,7 +62,7 @@ Only workspace admins can send invoices. Invoices can be sent directly from Expe
 If you have not [connected a business bank account](https://help.expensify.com/articles/new-expensify/expenses-&-payments/Connect-a-Business-Bank-Account) to receive invoice payments, you will see an **Invoice balance** in your [Wallet](https://help.expensify.com/articles/new-expensify/expenses-&-payments/Set-up-your-wallet). Expensify will automatically transfer these invoice payments once a business bank account is connected.


-# FAQs
+{% include faq-begin.md %}


You're missing an {% include faq-end.md %} at the end of the FAQ. This in turns makes a stray </div> appear at the end of the page:

Thanks @mjasikowski - do I need to approve the change or submit a new PR, I'm not finding that DIV anywhere in the changes

@Christinadobrzyn can you edit this PR to have {% include faq-end.md %} on line 93 of docs/articles/new-expensify/expenses-&-payments/Send-an-invoice.md? That's what @mjasikowski is saying that we are missing 👍

You added {% include faq-begin.md %} on line 65 but if you add that you also need to include a corresponding {% include faq-end.md %} in order to end the FAQ and have it styled correctly.

Ah yes, done! I added {% include faq-end.md %} to the end of both FAQ edits.

Christinadobrzyn · 2024-09-13T19:48:06Z

Gonna try to resolve that checklist error - I added it again in the OP but that didn't resolve it. Going to add it here as a new comment to see if that works.

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

blimpich · 2024-09-13T22:39:09Z

@Christinadobrzyn the failing check is because neither @mjasikowski or I have done the checklist as a reviewer, you're good on the Author side

blimpich · 2024-09-13T22:39:20Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

removed <div> from the end of the article (line 56 or something) and added {% include faq-end.md %}

removed <div> and added {% include faq-end.md %} to the end of the article

Added {% include faq-end.md %} to the end of the FAQ section

blimpich

Couple more tweaks, getting close.

blimpich · 2024-09-16T17:50:10Z

docs/articles/new-expensify/expenses-&-payments/Pay-an-invoice.md

-</div>
+{% include faq-end.md %}


Can you revert this? We already have a {% include faq-end.md %} on line 56 here, and we also need the </div> tag in order to close the opening <div> tag from line 5 of this file.

By "revert" I mean add the div tag back and get rid of the {% include faq-end.md %}

Ah okay, I updated the article! TY!

blimpich · 2024-09-16T17:55:02Z

docs/articles/new-expensify/expenses-&-payments/Send-an-invoice.md

-
-</div>
+{% include faq-end.md %}


We don't want to delete the </div>. We have an opening <div> tag on line 5 of this file, and this is its closing tag. Please see this article for an example of what we want.

It should be like this:

{% include faq-end.md %} </div>

Ah, okay, I updated the article!

added this to the end of the article. {% include faq-end.md %} </div>

added this to the end of the article {% include faq-end.md %} </div>

blimpich

LGTM! All yours @mjasikowski

Related to GH - Expensify/Expensify#427929 Adding images to the article - https://help.expensify.com/articles/new-expensify/expenses-&-payments/Pay-an-invoice

Related GH: Expensify/Expensify#427929 Related help article: https://help.expensify.com/articles/new-expensify/expenses-&-payments/Pay-an-invoice

Christinadobrzyn · 2024-09-16T23:04:57Z

Hi! just a side note that I added two images to this PR as part of this GH https://github.com/Expensify/Expensify/issues/427929 so I don't know if you need to review those additional parts of this PR @blimpich

blimpich · 2024-09-17T17:24:23Z

@mjasikowski all yours

mjasikowski · 2024-09-20T07:34:24Z

all good!

OSBotify · 2024-09-24T19:29:32Z

🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.0.40-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

github-actions · 2024-09-27T17:44:27Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.0.40-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Christinadobrzyn added 2 commits September 12, 2024 13:15

Update Pay-an-invoice.md

4909da0

trying to remove the duplicate FAQ section from the side bar

Update Send-an-invoice.md

e79f049

Updating the FAQ section so it collapses

Christinadobrzyn requested a review from a team as a code owner September 12, 2024 19:19

Christinadobrzyn requested review from blimpich and removed request for a team September 12, 2024 19:20

Christinadobrzyn self-assigned this Sep 12, 2024

melvin-bot bot requested a review from mjasikowski September 12, 2024 19:20

Create Set-up-workflows.md

4f988c0

Creating a new webpage for workflows

mjasikowski previously approved these changes Sep 13, 2024

View reviewed changes

mjasikowski requested changes Sep 13, 2024

View reviewed changes

Christinadobrzyn added 3 commits September 16, 2024 10:31

Update Pay-an-invoice.md

8c4e825

removed <div> from the end of the article (line 56 or something) and added {% include faq-end.md %}

Update Send-an-invoice.md

96249e1

removed <div> and added {% include faq-end.md %} to the end of the article

Update Set-up-workflows.md

0b6b3c1

Added {% include faq-end.md %} to the end of the FAQ section

blimpich requested changes Sep 16, 2024

View reviewed changes

blimpich and others added 3 commits September 16, 2024 11:47

Merge branch 'main' into christina-invoice-images

6c8f6c7

Update Send-an-invoice.md

f03482f

added this to the end of the article. {% include faq-end.md %} </div>

Update Pay-an-invoice.md

0873bd1

added this to the end of the article {% include faq-end.md %} </div>

blimpich previously approved these changes Sep 16, 2024

View reviewed changes

Add images to Pay-an-invoice help article

c88dad5

Related to GH - Expensify/Expensify#427929 Adding images to the article - https://help.expensify.com/articles/new-expensify/expenses-&-payments/Pay-an-invoice

Christinadobrzyn dismissed blimpich’s stale review via c88dad5 September 16, 2024 22:56

Christinadobrzyn requested a review from a team as a code owner September 16, 2024 22:56

Adding image to Pay-an-Invoice help article

684affb

Related GH: Expensify/Expensify#427929 Related help article: https://help.expensify.com/articles/new-expensify/expenses-&-payments/Pay-an-invoice

blimpich approved these changes Sep 16, 2024

View reviewed changes

blimpich requested a review from mjasikowski September 17, 2024 17:23

mjasikowski approved these changes Sep 20, 2024

View reviewed changes

mjasikowski merged commit 00d2e32 into main Sep 20, 2024
10 checks passed

mjasikowski deleted the christina-invoice-images branch September 20, 2024 07:34

github-actions bot mentioned this pull request Sep 24, 2024

Deploy Checklist: New Expensify 2024-09-24 #49662

Closed

67 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Pay an Invoice and Send an Invoice FAQ section so it collapses #49135

Update Pay an Invoice and Send an Invoice FAQ section so it collapses #49135

Christinadobrzyn commented Sep 12, 2024 •

edited

Loading

melvin-bot bot commented Sep 12, 2024

OSBotify commented Sep 12, 2024 •

edited

Loading

blimpich commented Sep 12, 2024

mjasikowski left a comment

mjasikowski Sep 13, 2024 •

edited

Loading

Christinadobrzyn Sep 13, 2024

blimpich Sep 13, 2024

Christinadobrzyn Sep 16, 2024

Christinadobrzyn commented Sep 13, 2024

blimpich commented Sep 13, 2024

blimpich commented Sep 13, 2024 •

edited

Loading

blimpich left a comment

blimpich Sep 16, 2024

blimpich Sep 16, 2024

Christinadobrzyn Sep 16, 2024

blimpich Sep 16, 2024

Christinadobrzyn Sep 16, 2024

blimpich left a comment

Christinadobrzyn commented Sep 16, 2024

blimpich commented Sep 17, 2024

mjasikowski commented Sep 20, 2024

OSBotify commented Sep 24, 2024

github-actions bot commented Sep 27, 2024

Update Pay an Invoice and Send an Invoice FAQ section so it collapses #49135

Update Pay an Invoice and Send an Invoice FAQ section so it collapses #49135

Conversation

Christinadobrzyn commented Sep 12, 2024 • edited Loading

Details

PR Author Checklist

melvin-bot bot commented Sep 12, 2024

OSBotify commented Sep 12, 2024 • edited Loading

blimpich commented Sep 12, 2024

mjasikowski left a comment

Choose a reason for hiding this comment

mjasikowski Sep 13, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Christinadobrzyn commented Sep 13, 2024

PR Author Checklist

blimpich commented Sep 13, 2024

blimpich commented Sep 13, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

blimpich left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

blimpich left a comment

Choose a reason for hiding this comment

Christinadobrzyn commented Sep 16, 2024

blimpich commented Sep 17, 2024

mjasikowski commented Sep 20, 2024

OSBotify commented Sep 24, 2024

github-actions bot commented Sep 27, 2024

Christinadobrzyn commented Sep 12, 2024 •

edited

Loading

OSBotify commented Sep 12, 2024 •

edited

Loading

mjasikowski Sep 13, 2024 •

edited

Loading

blimpich commented Sep 13, 2024 •

edited

Loading