Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/migrate to official s2 library #76

Merged
merged 12 commits into from
Mar 4, 2024

Conversation

victorgarcia98
Copy link
Collaborator

No description provided.

GustaafL and others added 10 commits February 7, 2024 08:49
Signed-off-by: GustaafL <guus@seita.nl>
Signed-off-by: GustaafL <guus@seita.nl>
Signed-off-by: GustaafL <guus@seita.nl>
Signed-off-by: GustaafL <guus@seita.nl>
Signed-off-by: GustaafL <guus@seita.nl>
Signed-off-by: GustaafL <guus@seita.nl>
Signed-off-by: Guus Linzel <41048720+GustaafL@users.noreply.github.com>
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
Base automatically changed from refactor/add-typing to main February 16, 2024 14:45
Copy link
Collaborator

@GustaafL GustaafL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice to have the official s2 package in there

* add dummy methods to return `Ok`Status code for the message types Timer and Transition

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>

* Timer and Transition are not message types, the message type that we want to support is FRBCTimerStatus

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>

---------

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
@victorgarcia98 victorgarcia98 merged commit 7be2645 into main Mar 4, 2024
5 of 6 checks passed
@victorgarcia98 victorgarcia98 deleted the feature/migrate-to-official-s2-library branch March 4, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants