feature/add support for more message types #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er and Transition Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
…want to support is FRBCTimerStatus Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
victorgarcia98
merged commit 3f7e13b
into
feature/migrate-to-official-s2-library
6 checks passed
victorgarcia98
added a commit
that referenced
this pull request
Mar 4, 2024
* refactor(client): Add static typing Signed-off-by: GustaafL <guus@seita.nl> * refactor(client): Add error checking for wrong content type Signed-off-by: GustaafL <guus@seita.nl> * refactor(client): type client.py Signed-off-by: GustaafL <guus@seita.nl> * refactor(cem): type as much some of the code Signed-off-by: GustaafL <guus@seita.nl> * feat(mypy): add mypy to pre-commit checks Signed-off-by: GustaafL <guus@seita.nl> * refactor(typing): add types for constraints and async parts Signed-off-by: GustaafL <guus@seita.nl> * Update ci.yml Signed-off-by: Guus Linzel <41048720+GustaafL@users.noreply.github.com> * add new dependencies Signed-off-by: Victor Garcia Reolid <victor@seita.nl> * migrate to the official s2 library Signed-off-by: Victor Garcia Reolid <victor@seita.nl> * remove old s2 message validation module Signed-off-by: Victor Garcia Reolid <victor@seita.nl> * feature/add support for more message types (#77) * add dummy methods to return `Ok`Status code for the message types Timer and Transition Signed-off-by: Victor Garcia Reolid <victor@seita.nl> * Timer and Transition are not message types, the message type that we want to support is FRBCTimerStatus Signed-off-by: Victor Garcia Reolid <victor@seita.nl> --------- Signed-off-by: Victor Garcia Reolid <victor@seita.nl> --------- Signed-off-by: GustaafL <guus@seita.nl> Signed-off-by: Guus Linzel <41048720+GustaafL@users.noreply.github.com> Signed-off-by: Victor Garcia Reolid <victor@seita.nl> Co-authored-by: GustaafL <guus@seita.nl> Co-authored-by: Guus Linzel <41048720+GustaafL@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Messages:
FRBCTimerStatus