Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avalonia #325

Merged
merged 109 commits into from
Feb 1, 2023
Merged

Avalonia #325

merged 109 commits into from
Feb 1, 2023

Conversation

ForNeVeR
Copy link
Owner

@ForNeVeR ForNeVeR commented Dec 30, 2022 •
edited
Loading

Closes #17.

TODO (extracted from #17 for convenience)

  • solve Extract WPF-dependent code into a separate project #63 in the branch
  • Deal with Merge branch 'master' into 'feature/17-avalonia' #347
  • Fix compilation
  • Fix tests
  • remove the code duplication (at least most of it) — that's why Extract WPF-dependent code into a separate project #63 was necessary
  • update the documentation
  • check issue \colorbox renders root index invisible #128: it should'nt be reproducible for WPF and for Avalonia
  • currently we're planning to only allow for solid colors in the portable code base; we'll have to think about supporting for non-solid colors (aka Brushes) for WPF- and Avalonia-dependent code
    • platform-specific IBrush instances allow that
  • Make sure the resources (.xml and .ttf) are deduplicated properly.
  • after all of that, Avalonia may land into the master branch
  • Check if we still need to override AvaloniaUseExternalMSBuild.
  • add Linux and macOS CI
  • Make sure the CI still works
  • Make sure to add the Avalonia assemblies into the API tests
  • WpfMath.Shared: make sure the framework list is correct (add netstandard)
  • Separate NuGet package for Avalonia
  • Separate NuGet package for WpfMath.Shared
  • Figure out and document the API changes
  • Share the versioning and copyright details
  • Update the maintainership documentation
  • nuget.yml: make sure it uses the same runner image as the main.yml
  • Merge with master, make sure the CI is still okay

Before merge

  • Review
  • TODO monitoring
  • Update GitHub Actions branch protection rules to use the new names

After merge

  • Create an issue about test suite refactoring: split tests into WPF-specific + Avalonia-specific + Shared
  • Create an issue about sharing the .ttf files somehow
  • Update the GitHub Action secrets
  • Create an issue on documenting the supported rendering targets
  • Create an issue on better control API documentation (e.g. the ErrorTemplate doesn't seem to be explained well)

ahopper and others added 30 commits December 5, 2018 14:05
@ahopper
Initial import of avalonia port
68701cb
@ahopper
FormulaControl replaced with FormulaBlock
d21d5e7
@ForNeVeR
Changed to be used with avalonia-ui. (updated ~ F. v. Never)
1a32031 
- Custom fonts are not working (math symbols are not working)
- Positions of the formula symbols are incorrect
- Project Properties removed as interrupting build

The added code was moved to another directory so it won't break the
original WPF code. ~ F. v. Never
@ForNeVeR
Compilation fix for GeometryGroup (#17)
6e01994
@ForNeVeR
Merge master into the Avalonia branch
0d8b957
@ForNeVeR
Update the build script to include new solution
acaeb98
@ForNeVeR
Reference the released Avalonia instead of beta (#17)
903d6f6
@ForNeVeR
Merge branch 'feature/17-avalonia' into 'pull/170-rebased'
1b6dead
@ForNeVeR
Fix comment for TexFontInfo.GetMetrics
939fa0c
@ForNeVeR
Review fixes (#17)
0f88a21
@ForNeVeR
Merge branch 'master' into feature/17-avalonia
e9ce178 
# Conflicts:
#	appveyor.yml
#	src/WpfMath/WpfMath.csproj
@ForNeVeR
Update Avalonia to 0.8, prepare package (#17)
71480f5
@ForNeVeR
Update a package publishing script (#17)
d865996
@ForNeVeR
Add Avalonia-Math information into the README file (#17)
fd5c3b4
@rstm-sf
Merge branch 'master' into infra/merge_master_into_avalonia
4c77dc8 
# Conflicts:
#	README.md
#	WpfMath.sln
#	appveyor.yml
#	scripts/nuget-pack.ps1
#	src/SharedMath/Atoms/BigDelimeterAtom.cs
#	src/SharedMath/DefaultTexFont.cs
#	src/SharedMath/TexFontUtilities.cs
#	src/SharedMath/XmlUtilities.cs
#	src/WpfMath/TexFontInfo.cs
@rstm-sf
Fix Avalonia/TexFormula
22a067e
@rstm-sf
Remove BOM
3063a33
@rstm-sf
Fix resolving conflicts
2a41b83
@rstm-sf
Update Avalonia/TexPredefinedFormulaParser
35c75c2
@rstm-sf
Update Avalonia/StyledAtom
1434076
@rstm-sf
Update Avalonia/Box
149f952
@rstm-sf
Move some WPF elements to the SharedMath
ae91253
@rstm-sf
Copy-paste to Avalonia/Colors from WPF/Colors
f56f490
@rstm-sf
Update Avalonia/TexFormulaParser and TexUtilities
cb824ab
@rstm-sf
Update Avalonia/IElementRenderer
363f2cf
@rstm-sf
Update Avalonia/Data
8413062
@rstm-sf
Fix create color
19bcf7d
@rstm-sf
Fix formula in view
78266b9
@rstm-sf @ForNeVeR
Update Avalonia/*.csproj
57a0def
@rstm-sf @ForNeVeR
Fix todo for \underline in Avalonia
9800789
@ForNeVeR ForNeVeR marked this pull request as ready for review January 31, 2023 23:42
@ForNeVeR
(#17) Tests: update Microsoft.Net.Test.SDK
bde9973 
Otherwise, tests may be unstable.
@ForNeVeR ForNeVeR mentioned this pull request Feb 1, 2023
Open
@ForNeVeR ForNeVeR mentioned this pull request Feb 1, 2023
Open
@ForNeVeR ForNeVeR mentioned this pull request Feb 1, 2023
Open
1 task
@ForNeVeR ForNeVeR mentioned this pull request Feb 1, 2023
Open
This was referenced Feb 1, 2023
Open
Open
@ForNeVeR ForNeVeR merged commit 42b0754 into master Feb 1, 2023
@ForNeVeR ForNeVeR deleted the feature/17-avalonia branch February 3, 2023 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ForNeVeR ForNeVeR

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avalonia support
3 participants
@ForNeVeR @ahopper @rstm-sf