Add warning message to proxy settings #6099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
PR: waiting for review
ChunkyProgrammer
requested review from
PikachuEXE,
absidue,
efb4f5ff-1298-471a-8973-3d47447115dc and
kommunarr
PikachuEXE
reviewed
Nov 5, 2024
absidue
reviewed
Nov 6, 2024
|
Going to play devils advocate here, why go for this banner instead of our standard tooltip offtopic discussion: should we also use a banner for other settings? |
|
I think part of the problem here is the naming of the setting itself "enable proxy/tor" sounds like you can just turn it on like other settings and it will just work, something along the lines of "connect to external proxy" with a subtitle of "enter the connection details for your proxy below" might make it more obvious what the setting actually does. |
|
|
absidue
previously approved these changes
Nov 18, 2024
Thoughts? |
|
Ya that one would be noticeable |
Co-authored-by: PikachuEXE <git@pikachuexe.net>
ChunkyProgrammer
force-pushed
the
add-warning-message-to-proxy-settings
branch
from
cd103e2 to
0a331a6
Compare
absidue
approved these changes
Nov 20, 2024
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Nov 23, 2024
kommunarr
approved these changes
Nov 23, 2024
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Nov 24, 2024
* development: (273 commits) Translated using Weblate (Serbian) Translated using Weblate (Czech) Translated using Weblate (French) Translated using Weblate (German) Translated using Weblate (Spanish) Fix text colour in player overflow menu (FreeTubeApp#6213) Add warning message to proxy settings (FreeTubeApp#6099) Migrate SubscribedChannels view to Composition API (FreeTubeApp#6131) Translated using Weblate (Croatian) Translated using Weblate (English (United Kingdom)) Translated using Weblate (Afrikaans) Translated using Weblate (Afrikaans) Better player error handling (FreeTubeApp#6180) Translated using Weblate (Arabic) Translated using Weblate (Afrikaans) local API: Fix playlists and podcasts not appearing in search results (FreeTubeApp#6196) Translated using Weblate (Serbian) Translated using Weblate (Hungarian) Bump shaka-player from 4.11.11 to 4.12.1 (FreeTubeApp#6193) Translated using Weblate (French) ... # Conflicts: # src/renderer/views/SubscribedChannels/SubscribedChannels.js
Soham456
pushed a commit
to Soham456/FreeTube
that referenced
this pull request
Dec 5, 2024
* Add warning message to proxy settings * Update src/renderer/components/proxy-settings/proxy-settings.css Co-authored-by: PikachuEXE <git@pikachuexe.net> * simplify message * Only show banner when useProxy is enabled --------- Co-authored-by: PikachuEXE <git@pikachuexe.net>
jlvivero
pushed a commit
to jlvivero/FreeTube
that referenced
this pull request
Dec 7, 2024
* Add warning message to proxy settings * Update src/renderer/components/proxy-settings/proxy-settings.css Co-authored-by: PikachuEXE <git@pikachuexe.net> * simplify message * Only show banner when useProxy is enabled --------- Co-authored-by: PikachuEXE <git@pikachuexe.net>
SuperAKWA
pushed a commit
to SuperAKWA/FreeTube
that referenced
this pull request
Jan 24, 2025
* Add warning message to proxy settings * Update src/renderer/components/proxy-settings/proxy-settings.css Co-authored-by: PikachuEXE <git@pikachuexe.net> * simplify message * Only show banner when useProxy is enabled --------- Co-authored-by: PikachuEXE <git@pikachuexe.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add warning message to proxy settings
Pull Request Type
Related issue
It isn't clear for non-power users that you actually have to set up a proxy/set up Tor to get it to work. This change should remove some of that confusion.
Description
Adds a warning message under the proxy settings saying you need to setup a proxy/Tor and configure it or FreeTube won't work
Screenshots
Testing
Desktop