Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate SubscribedChannels view to Composition API #6131

Conversation

ChunkyProgrammer
Copy link
Member

Migrate SubscribedChannels view to Composition API

Pull Request Type

  • Refactoring - Composition API migration

Description

This pull request migrates the SubscribedChannels view to the composition API.

Testing

  • go to subscribed channels view
  • filter channels

Desktop

  • OS: Linux Mint
  • OS Version: 22
  • FreeTube version: 0.22.0

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) November 10, 2024 16:05
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Nov 10, 2024
ChunkyProgrammer and others added 2 commits November 17, 2024 22:35
Co-Authored-By: absidue <48293849+absidue@users.noreply.github.com>
@ChunkyProgrammer ChunkyProgrammer force-pushed the migrate-subscribedchannels-to-composition-api branch from 1620257 to d838fbe Compare November 18, 2024 03:35
@FreeTubeBot FreeTubeBot merged commit 2cead47 into FreeTubeApp:development Nov 23, 2024
5 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Nov 23, 2024
PikachuEXE added a commit to PikachuEXE/FreeTube that referenced this pull request Nov 24, 2024
* development: (273 commits)
  Translated using Weblate (Serbian)
  Translated using Weblate (Czech)
  Translated using Weblate (French)
  Translated using Weblate (German)
  Translated using Weblate (Spanish)
  Fix text colour in player overflow menu (FreeTubeApp#6213)
  Add warning message to proxy settings (FreeTubeApp#6099)
  Migrate SubscribedChannels view to Composition API (FreeTubeApp#6131)
  Translated using Weblate (Croatian)
  Translated using Weblate (English (United Kingdom))
  Translated using Weblate (Afrikaans)
  Translated using Weblate (Afrikaans)
  Better player error handling (FreeTubeApp#6180)
  Translated using Weblate (Arabic)
  Translated using Weblate (Afrikaans)
  local API: Fix playlists and podcasts not appearing in search results (FreeTubeApp#6196)
  Translated using Weblate (Serbian)
  Translated using Weblate (Hungarian)
  Bump shaka-player from 4.11.11 to 4.12.1 (FreeTubeApp#6193)
  Translated using Weblate (French)
  ...

# Conflicts:
#	src/renderer/views/SubscribedChannels/SubscribedChannels.js
Soham456 pushed a commit to Soham456/FreeTube that referenced this pull request Dec 5, 2024
* Migrate SubscribedChannels view to Composition API

* make thumbnailsize and errorcount unreactive

Co-Authored-By: absidue <48293849+absidue@users.noreply.github.com>

---------

Co-authored-by: absidue <48293849+absidue@users.noreply.github.com>
jlvivero pushed a commit to jlvivero/FreeTube that referenced this pull request Dec 7, 2024
* Migrate SubscribedChannels view to Composition API

* make thumbnailsize and errorcount unreactive

Co-Authored-By: absidue <48293849+absidue@users.noreply.github.com>

---------

Co-authored-by: absidue <48293849+absidue@users.noreply.github.com>
@ChunkyProgrammer ChunkyProgrammer deleted the migrate-subscribedchannels-to-composition-api branch December 27, 2024 21:48
SuperAKWA pushed a commit to SuperAKWA/FreeTube that referenced this pull request Jan 24, 2025
* Migrate SubscribedChannels view to Composition API

* make thumbnailsize and errorcount unreactive

Co-Authored-By: absidue <48293849+absidue@users.noreply.github.com>

---------

Co-authored-by: absidue <48293849+absidue@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants