Fix text colour in player overflow menu #6213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer,
kommunarr and
MarmadileManteater
github-actions
bot
added
the
PR: waiting for review
PikachuEXE
approved these changes
Nov 23, 2024
kommunarr
approved these changes
Nov 23, 2024
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Nov 23, 2024
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Nov 24, 2024
* development: (273 commits) Translated using Weblate (Serbian) Translated using Weblate (Czech) Translated using Weblate (French) Translated using Weblate (German) Translated using Weblate (Spanish) Fix text colour in player overflow menu (FreeTubeApp#6213) Add warning message to proxy settings (FreeTubeApp#6099) Migrate SubscribedChannels view to Composition API (FreeTubeApp#6131) Translated using Weblate (Croatian) Translated using Weblate (English (United Kingdom)) Translated using Weblate (Afrikaans) Translated using Weblate (Afrikaans) Better player error handling (FreeTubeApp#6180) Translated using Weblate (Arabic) Translated using Weblate (Afrikaans) local API: Fix playlists and podcasts not appearing in search results (FreeTubeApp#6196) Translated using Weblate (Serbian) Translated using Weblate (Hungarian) Bump shaka-player from 4.11.11 to 4.12.1 (FreeTubeApp#6193) Translated using Weblate (French) ... # Conflicts: # src/renderer/views/SubscribedChannels/SubscribedChannels.js
Soham456
pushed a commit
to Soham456/FreeTube
that referenced
this pull request
Dec 5, 2024
jlvivero
pushed a commit
to jlvivero/FreeTube
that referenced
this pull request
Dec 7, 2024
| @@ -67,6 +67,10 @@ | |||
| color: var(--side-nav-hover-text-color) !important; | |||
| } | |||
|
|
|||
| :deep(.shaka-current-selection-span) { | |||
There was a problem hiding this comment.
@absidue This also affects the color of the stats button text, which can render it nearly invisible depending on your theme.
How about:
:deep(.shaka-overflow-menu-only .shaka-current-selection-span) {
There was a problem hiding this comment.
@OothecaPickle could you open up an issue for this so this doesnt get lost
There was a problem hiding this comment.
@OothecaPickle could you open up an issue for this so this doesnt get lost
1 task
SuperAKWA
pushed a commit
to SuperAKWA/FreeTube
that referenced
this pull request
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix text colour in player overflow menu
Pull Request Type
Related issue
Description
This pull request fixes the currently active base theme not being applied to the "current selection" texts in the player overflow menu.
Screenshots
Before:
After:
Testing
Desktop