-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support Vector input for Scripts, improve overall Vector input support #1046
Conversation
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success1014 tests passing in 182 suites. Report generated by 🧪jest coverage report action from 941c23d |
@Torres-ssf Ok I've updated the implementation to better handle data like that, and I've added some more tests to account for the changes, including two Sway applications and some unit tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🪄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A nit on the return statements of AbiCoder
and a request for change/explanation on the use of double tildes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, really appreciate the more complex test cases being used also
941c23d
Fixes #1015
This is a total rewrite of how Vectors work, removing the previous version I implemented and packing Vector data alongside its pointer, to be dynamically appended at the last step of the Abi Coder, see
concatWithVectorData
.Also see: