feat: add Vec support as an Input #497
Conversation
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success503 tests passing in 44 suites. Report generated by 🧪jest coverage report action from 7827436 |
packages/contract/src/__test__/coverage-contract/coverage-contract.test.ts
Show resolved
Hide resolved
packages/abi-coder/src/constants.ts
Outdated
| WORD_SIZE + // Byte price | ||
| WORD_SIZE + // Maturity | ||
| WORD_SIZE + // Script size | ||
| // WORD_SIZE + // Script data size |
There was a problem hiding this comment.
is this supposed to be commented?
There was a problem hiding this comment.
That's a good question!
The pointer for script data used in vector location is built upon vm TX memory offset + script bytes length (padded to word size) + base transaction size (this var) + script data length
In my case this particular calculation was off by 8 bytes, so my assumption was that this line of code was the issue because script data size is calculated dynamically.
I may be way off base here, would love others to weigh in @luizstacio @adlerjohn @digorithm
There was a problem hiding this comment.
The correct field to remove is WORD_SIZE + // Byte price which was removed on fuel-core v0.10.
There was a problem hiding this comment.
Updated - thanks @luizstacio !
| @@ -4,7 +4,7 @@ | |||
| "declaration": true, | |||
| "declarationMap": true, | |||
| "esModuleInterop": true, | |||
| "lib": ["ES2020"], | |||
| "lib": ["ES2021"], | |||
There was a problem hiding this comment.
Do we need to change this? Any impact on the build also?
There was a problem hiding this comment.
This was to address the issue in LogReader. I had some notes on it there regarding the ts-lint ignore. I'm happy to revert this and reinstate the comment there
There was a problem hiding this comment.
@luizstacio see here for motivation of this change #497 (comment)
packages/abi-coder/src/constants.ts
Outdated
| WORD_SIZE + // Byte price | ||
| WORD_SIZE + // Maturity | ||
| WORD_SIZE + // Script size | ||
| // WORD_SIZE + // Script data size |
There was a problem hiding this comment.
The correct field to remove is WORD_SIZE + // Byte price which was removed on fuel-core v0.10.
Closes #434
Here is a basic example of my thought process, also see #434 for greater details
