-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correctly offset vector input #910
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camsjams
requested review from
arboleya,
LuizAsFight,
danielbate,
Torres-ssf,
Dhaiwat10 and
a team
April 19, 2023 06:38
camsjams
commented
Apr 19, 2023
camsjams
commented
Apr 19, 2023
camsjams
commented
Apr 19, 2023
Coverage report
Show files with reduced coverage 🔻
Test suite run success794 tests passing in 115 suites. Report generated by 🧪jest coverage report action from 80f9cc5 |
Dhaiwat10
approved these changes
Apr 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally 😅
Torres-ssf
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aside from fixing the issue, to get there I had to write some tests and iron out the exact nuances. The final result looks simpler overall, but there were some fun bugs to kill as I changed the Vec data code.
I've added a lot of unit tests in different places as a result.
Issue
The
pointer
of the Vector data was wrong, caused by a bug when the index of the first vector param was not zero.Solution
By always starting with the base offset, the bug is fixed.
These lines were the culprit, as this would only run if the first vector was also the first input:
Fixes #881
Note: I'd recommend also seeing the original PR here: #497 which includes a still accurate diagram.