Apply on_enter edits from the client #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmmm that is rather slow. Perhaps we could put this feature behind a toggle in the config and have it default to being turned off. That we we can land this work and then debug how to speed it up later. How does that sound? |
JoshuaBatty
reviewed
Jul 28, 2023
JoshuaBatty
approved these changes
Jul 28, 2023
sdankel
added a commit
that referenced
this pull request
Apr 17, 2024
* Apply on_enter edits from the client * Default to false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related FuelLabs/sway#4728
Adds a listener for file changes which calls the new on_enter custom method when a file change containing a newline has been made. The result is we get better performance for comment continuation. It's still slow, however.
I timed the actual logic that builds the Workspace Edit, and that part is extremely fast. From the logs I can see that the response is ready to go, but can take several seconds to be returned to the client. Meanwhile, other LSP responses are taking similar amounts of time (1-3 seconds).
Note: I will wait for the server change to be release before releasing this change, otherwise there could be errors.