Comment continuation isn't working anymore? #4728
Assignees
Labels
Comments
|
This is happening for me too! Doc comment continuation is still working for me, but not comment continuation. Looking into it. |
|
Weird, after updating VSCode, both are now working for me. I plan to replace this with a custom on_enter method implementation to remove the dependency on the client to apply edits which will hopefully also make this more robust. |
This was referenced Jul 26, 2023
sdankel
added a commit
that referenced
this issue
Jul 28, 2023
## Description Closes #4728 Moves the on_enter capabilities to a custom LSP method that simply returns the edits to the client, rather than directly applying the edits as part of did_change. With this approach, there is still some lag if you hit enter many times, but it seems to be working better than before. ## Checklist - [x] I have linked to any relevant issues. - [ ] I have commented my code, particularly in hard-to-understand areas. - [ ] I have updated the documentation where relevant (API docs, the reference, and the Sway book). - [ ] I have added tests that prove my fix is effective or that my feature works. - [ ] I have added (or requested a maintainer to add) the necessary `Breaking*` or `New Feature` labels where relevant. - [ ] I have done my best to ensure that my PR adheres to [the Fuel Labs Code Review Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md). - [ ] I have requested a review from the relevant team or maintainers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm just getting everything set up on my new machine and noticed that
on_enterisn't adding//or///in the editor even though I have both settings set to on.@sdankel not sure if this is happening for you also?
The text was updated successfully, but these errors were encountered: