Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom on_enter LSP method #4876

Merged
merged 8 commits into from
Jul 28, 2023
Merged

Custom on_enter LSP method #4876

merged 8 commits into from
Jul 28, 2023

Conversation

sdankel
Copy link
Member

@sdankel sdankel commented Jul 26, 2023

Description

Closes #4728

Moves the on_enter capabilities to a custom LSP method that simply returns the edits to the client, rather than directly applying the edits as part of did_change.

With this approach, there is still some lag if you hit enter many times, but it seems to be working better than before.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@sdankel sdankel requested review from JoshuaBatty and a team July 27, 2023 02:06
@sdankel sdankel marked this pull request as ready for review July 27, 2023 02:06
@JoshuaBatty JoshuaBatty requested a review from a team July 28, 2023 02:24
@JoshuaBatty JoshuaBatty added the language server LSP server label Jul 28, 2023
@JoshuaBatty JoshuaBatty requested a review from a team July 28, 2023 04:25
@sdankel sdankel merged commit 492870b into master Jul 28, 2023
@sdankel sdankel deleted the sophie/onEnterCustom branch July 28, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comment continuation isn't working anymore?
3 participants