-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for Access Context Manager's VPC Sub-segmentation feature #8989
Conversation
… and tests updated.
Hello! I am a robot. It looks like you are a: @SarahFrench, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 18 files changed, 1241 insertions(+), 8 deletions(-)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_access_context_manager_service_perimeter" "primary" {
spec {
egress_policies {
egress_from {
source_restriction = # value needed
sources {
access_level = # value needed
resource = # value needed
}
}
}
}
status {
egress_policies {
egress_from {
sources {
resource = # value needed
}
}
}
}
}
Resource: resource "google_access_context_manager_service_perimeter_egress_policy" "primary" {
egress_from {
source_restriction = # value needed
sources {
access_level = # value needed
resource = # value needed
}
}
}
Resource: resource "google_access_context_manager_service_perimeters" "primary" {
service_perimeters {
spec {
egress_policies {
egress_from {
source_restriction = # value needed
sources {
access_level = # value needed
resource = # value needed
}
}
}
}
status {
egress_policies {
egress_from {
sources {
resource = # value needed
}
}
}
}
}
}
|
Tests analyticsTotal tests: Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccAccessContextManager |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 18 files changed, 1241 insertions(+), 8 deletions(-)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_access_context_manager_service_perimeter" "primary" {
spec {
egress_policies {
egress_from {
source_restriction = # value needed
sources {
access_level = # value needed
resource = # value needed
}
}
}
}
status {
egress_policies {
egress_from {
sources {
resource = # value needed
}
}
}
}
}
Resource: resource "google_access_context_manager_service_perimeter_egress_policy" "primary" {
egress_from {
source_restriction = # value needed
sources {
access_level = # value needed
resource = # value needed
}
}
}
Resource: resource "google_access_context_manager_service_perimeters" "primary" {
service_perimeters {
spec {
egress_policies {
egress_from {
source_restriction = # value needed
sources {
access_level = # value needed
resource = # value needed
}
}
}
}
status {
egress_policies {
egress_from {
sources {
resource = # value needed
}
}
}
}
}
}
|
…moving a VPC network to the top level instead of (incorrectly) inside another resource.
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 18 files changed, 1254 insertions(+), 8 deletions(-)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_access_context_manager_service_perimeter" "primary" {
spec {
egress_policies {
egress_from {
source_restriction = # value needed
sources {
access_level = # value needed
resource = # value needed
}
}
}
}
status {
egress_policies {
egress_from {
sources {
resource = # value needed
}
}
}
}
}
Resource: resource "google_access_context_manager_service_perimeter_egress_policy" "primary" {
egress_from {
source_restriction = # value needed
sources {
access_level = # value needed
resource = # value needed
}
}
}
Resource: resource "google_access_context_manager_service_perimeters" "primary" {
service_perimeters {
spec {
egress_policies {
egress_from {
source_restriction = # value needed
sources {
access_level = # value needed
resource = # value needed
}
}
}
}
status {
egress_policies {
egress_from {
sources {
resource = # value needed
}
}
}
}
}
}
|
Tests analyticsTotal tests: Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccAccessContextManager|TestAccDataprocJobIamPolicy |
Rerun these tests in REPLAYING mode to catch issues
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 18 files changed, 1254 insertions(+), 13 deletions(-)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_access_context_manager_service_perimeter" "primary" {
spec {
egress_policies {
egress_from {
source_restriction = # value needed
sources {
access_level = # value needed
resource = # value needed
}
}
}
}
status {
egress_policies {
egress_from {
sources {
resource = # value needed
}
}
}
}
}
Resource: resource "google_access_context_manager_service_perimeter_egress_policy" "primary" {
egress_from {
source_restriction = # value needed
sources {
access_level = # value needed
resource = # value needed
}
}
}
Resource: resource "google_access_context_manager_service_perimeters" "primary" {
service_perimeters {
spec {
egress_policies {
egress_from {
source_restriction = # value needed
sources {
access_level = # value needed
resource = # value needed
}
}
}
}
status {
egress_policies {
egress_from {
sources {
resource = # value needed
}
}
}
}
}
}
|
Tests analyticsTotal tests: Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccAccessContextManager |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Breaking Change Detection FailedThe breaking change detector crashed during execution. This is usually due to the downstream provider(s) failing to compile. Please investigate or follow up with your reviewer. Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 18 files changed, 1378 insertions(+), 102 deletions(-)) |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 18 files changed, 1244 insertions(+), 9 deletions(-)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_access_context_manager_access_level_condition" "primary" {
vpc_network_sources {
vpc_subnetwork {
network = # value needed
vpc_ip_subnetworks = # value needed
}
}
}
Resource: resource "google_access_context_manager_service_perimeter" "primary" {
spec {
egress_policies {
egress_from {
source_restriction = # value needed
sources {
access_level = # value needed
resource = # value needed
}
}
}
}
status {
egress_policies {
egress_from {
sources {
resource = # value needed
}
}
}
}
}
Resource: resource "google_access_context_manager_service_perimeter_egress_policy" "primary" {
egress_from {
source_restriction = # value needed
sources {
access_level = # value needed
resource = # value needed
}
}
}
Resource: resource "google_access_context_manager_service_perimeters" "primary" {
service_perimeters {
spec {
egress_policies {
egress_from {
source_restriction = # value needed
sources {
access_level = # value needed
resource = # value needed
}
}
}
}
status {
egress_policies {
egress_from {
sources {
resource = # value needed
}
}
}
}
}
}
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 18 files changed, 1243 insertions(+), 13 deletions(-)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_access_context_manager_access_level_condition" "primary" {
vpc_network_sources {
vpc_subnetwork {
network = # value needed
vpc_ip_subnetworks = # value needed
}
}
}
Resource: resource "google_access_context_manager_service_perimeter" "primary" {
spec {
egress_policies {
egress_from {
source_restriction = # value needed
sources {
access_level = # value needed
resource = # value needed
}
}
}
}
status {
egress_policies {
egress_from {
sources {
resource = # value needed
}
}
}
}
}
Resource: resource "google_access_context_manager_service_perimeter_egress_policy" "primary" {
egress_from {
source_restriction = # value needed
sources {
access_level = # value needed
resource = # value needed
}
}
}
Resource: resource "google_access_context_manager_service_perimeters" "primary" {
service_perimeters {
spec {
egress_policies {
egress_from {
source_restriction = # value needed
sources {
access_level = # value needed
resource = # value needed
}
}
}
}
status {
egress_policies {
egress_from {
sources {
resource = # value needed
}
}
}
}
}
}
|
Tests analyticsTotal tests: Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccAccessContextManager|TestAccDataSourceGoogleServiceAccountJwt|TestAccProjectIamPolicy_invalidMembers |
Rerun these tests in REPLAYING mode to catch issues
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 18 files changed, 1254 insertions(+), 13 deletions(-)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_access_context_manager_service_perimeter" "primary" {
spec {
egress_policies {
egress_from {
source_restriction = # value needed
sources {
access_level = # value needed
resource = # value needed
}
}
}
}
status {
egress_policies {
egress_from {
sources {
resource = # value needed
}
}
}
}
}
Resource: resource "google_access_context_manager_service_perimeter_egress_policy" "primary" {
egress_from {
source_restriction = # value needed
sources {
access_level = # value needed
resource = # value needed
}
}
}
Resource: resource "google_access_context_manager_service_perimeters" "primary" {
service_perimeters {
spec {
egress_policies {
egress_from {
source_restriction = # value needed
sources {
access_level = # value needed
resource = # value needed
}
}
}
}
status {
egress_policies {
egress_from {
sources {
resource = # value needed
}
}
}
}
}
}
|
Tests analyticsTotal tests: Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccAccessContextManager |
|
… from the API returns. Also removing the 'resource' field because it's behind an allowlist.
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 18 files changed, 1119 insertions(+), 13 deletions(-)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_access_context_manager_service_perimeter" "primary" {
spec {
egress_policies {
egress_from {
source_restriction = # value needed
sources {
access_level = # value needed
}
}
}
}
}
Resource: resource "google_access_context_manager_service_perimeter_egress_policy" "primary" {
egress_from {
source_restriction = # value needed
sources {
access_level = # value needed
}
}
}
Resource: resource "google_access_context_manager_service_perimeters" "primary" {
service_perimeters {
spec {
egress_policies {
egress_from {
source_restriction = # value needed
sources {
access_level = # value needed
}
}
}
}
}
}
|
Tests analyticsTotal tests: Action takenFound 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccAccessContextManager|TestAccBigQueryDataTable_bigtable|TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample|TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample|TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample |
Rerun these tests in REPLAYING mode to catch issues
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 18 files changed, 1138 insertions(+), 21 deletions(-)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_access_context_manager_access_level_condition" "primary" {
vpc_network_sources {
vpc_subnetwork {
network = # value needed
vpc_ip_subnetworks = # value needed
}
}
}
Resource: resource "google_access_context_manager_service_perimeter" "primary" {
spec {
egress_policies {
egress_from {
source_restriction = # value needed
sources {
access_level = # value needed
}
}
}
}
}
Resource: resource "google_access_context_manager_service_perimeter_egress_policy" "primary" {
egress_from {
source_restriction = # value needed
sources {
access_level = # value needed
}
}
}
Resource: resource "google_access_context_manager_service_perimeters" "primary" {
service_perimeters {
spec {
egress_policies {
egress_from {
source_restriction = # value needed
sources {
access_level = # value needed
}
}
}
}
}
}
|
Tests analyticsTotal tests: Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccContainerCluster_withAddons |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 18 files changed, 1138 insertions(+), 22 deletions(-)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_access_context_manager_service_perimeter" "primary" {
spec {
egress_policies {
egress_from {
source_restriction = # value needed
sources {
access_level = # value needed
}
}
}
}
}
Resource: resource "google_access_context_manager_service_perimeter_egress_policy" "primary" {
egress_from {
source_restriction = # value needed
sources {
access_level = # value needed
}
}
}
Resource: resource "google_access_context_manager_service_perimeters" "primary" {
service_perimeters {
spec {
egress_policies {
egress_from {
source_restriction = # value needed
sources {
access_level = # value needed
}
}
}
}
}
}
|
Tests analyticsTotal tests: Action takenFound 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccAccessContextManager|TestAccContainerNodePool_withUpgradeSettings|TestAccContainerNodePool_withKubeletConfig|TestAccContainerCluster_withAddons|TestAccHealthcareDatasetIamPolicy |
Rerun these tests in REPLAYING mode to catch issues
|
Hi @SarahFrench, I see that the missing test report says that How can I get the missing test report to recognize these tests? |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 18 files changed, 1139 insertions(+), 23 deletions(-)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_access_context_manager_service_perimeter" "primary" {
spec {
egress_policies {
egress_from {
source_restriction = # value needed
sources {
access_level = # value needed
}
}
}
}
}
Resource: resource "google_access_context_manager_service_perimeter_egress_policy" "primary" {
egress_from {
source_restriction = # value needed
sources {
access_level = # value needed
}
}
}
Resource: resource "google_access_context_manager_service_perimeters" "primary" {
service_perimeters {
spec {
egress_policies {
egress_from {
source_restriction = # value needed
sources {
access_level = # value needed
}
}
}
}
}
}
|
Tests analyticsTotal tests: Action takenFound 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccContainerNodePool_withUpgradeSettings|TestAccContainerNodePool_withKubeletConfig|TestAccContainerCluster_withAddons|TestAccDataSourceGoogleServiceAccountJwt |
Rerun these tests in REPLAYING mode to catch issues
|
This might be a sign that the config defined in these tests is malformed somehow. This message says that a test for
I took the code you linked to and opened it in an IDE and it looks like instead of defining those fields in ![]() |
Ah, my apologies, it looks like you're also adding fields that are called the same thing and nested under the status field. I think you need to add the new Lines 264 to 285 in ad1898f
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given the repetitive nature of these new fields and the confusion with acceptance tests, could you please split this PR into multiple PRs?
@vmoros, this PR is waiting for action from you. Please address any comments or change requests, or re-request review from a core reviewer if no action is required. If no action is taken, this PR will be closed in 14 days. This notification can be disabled with the |
Superseded by #9298 |
Moving changes for Access Context Manager's VPC Sub-segmentation feature from Terraform EAP to the normal provider.
Here is the PR that added these same fields to Terraform EAP.
Here are the new fields for Service Perimeters, so this PR adds these new fields (and associated sub-fields) to various Service Perimeter-related tests and resource files.
Similarly, here is the new field for Access Levels. This PR adds this new field (and associated sub-fields) to various Access Level-related tests and resource files.
Release Note Template for Downstream PRs (will be copied)