Vgm vpc subseg #16327
Merged
Vgm vpc subseg #16327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* First commit for VPC sub-segmentation feature. All relevant resources and tests updated. * Adding access levels instead of using a fake access level name. Also moving a VPC network to the top level instead of (incorrectly) inside another resource. * Fixing conflict between ip_subnetworks and vpc_ip_subnetworks * Undoing changes to access level condition test * Undoing changes to access level condition test * Ran gofmt * Re-adding access level conditions tests * Changing resource names to camel case to match what the HTTP response from the API returns. Also removing the 'resource' field because it's behind an allowlist. * Parameterizing the names of VPC networks created in tests * Fixing access level condition test * Fixed formatting with gofmt * Added missing fields in egress_from for service perimeter test. * Added "required: true" for AccessLevel.VpcNetworkSource.network field to match description. * Added egress source changes to test data in: example_access_context_manager_service_perimeter.tfplan.json * Add Egress Source/source restriction changes to example_access_context_manager_service_perimeter.tf * Attempt to fix example_access_context_manager_service_perimeter.tfplan.json to make it parse correctly * Add Egress Source to expected tcg test result data * Fixing expected output format in example_access_context_manager_service_perimeter.json * Fix Access Level format in expected output in example_access_context_manager_service_perimeter.json --------- Co-authored-by: vgm <vgm@google.com> Co-authored-by: Viktor Moros <vmoros@users.noreply.github.com> [upstream:d30384c9aa2002c56102ce4c8f0c76c77706b923] Signed-off-by: Modular Magician <magic-modules@google.com>
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar PR as GoogleCloudPlatform/magic-modules#8989, but with additional fixes in the Service Perimeters tests.
Moving changes for Access Context Manager's VPC Sub-segmentation feature from Terraform EAP to the normal provider.
Here is the PR that added these same fields to Terraform EAP.
Here are the new fields for Service Perimeters, so this PR adds these new fields (and associated sub-fields) to various Service Perimeter-related tests and resource files.
Similarly, here is the new field for Access Levels. This PR adds this new field (and associated sub-fields) to various Access Level-related tests and resource files.
Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#9298