-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vgm vpc subseg #9298
Vgm vpc subseg #9298
Conversation
… and tests updated.
…moving a VPC network to the top level instead of (incorrectly) inside another resource.
… from the API returns. Also removing the 'resource' field because it's behind an allowlist.
Hello! I am a robot. It looks like you are a: @slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 18 files changed, 1143 insertions(+), 23 deletions(-)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_access_context_manager_service_perimeter_egress_policy" "primary" {
egress_from {
source_restriction = # value needed
sources {
access_level = # value needed
}
}
}
Resource: resource "google_access_context_manager_service_perimeters" "primary" {
service_perimeters {
spec {
egress_policies {
egress_from {
source_restriction = # value needed
sources {
access_level = # value needed
}
}
}
}
}
}
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 18 files changed, 1143 insertions(+), 23 deletions(-)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_access_context_manager_service_perimeter_egress_policy" "primary" {
egress_from {
source_restriction = # value needed
sources {
access_level = # value needed
}
}
}
Resource: resource "google_access_context_manager_service_perimeters" "primary" {
service_perimeters {
spec {
egress_policies {
egress_from {
source_restriction = # value needed
sources {
access_level = # value needed
}
}
}
}
}
}
|
Tests analyticsTotal tests: Action takenFound 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccAccessContextManager|TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample|TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample|TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample |
Rerun these tests in REPLAYING mode to catch issues
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple changes needed based on the description of the fields not matching the function.
Other than that, looks good to me, thanks for adding tests!
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 18 files changed, 1143 insertions(+), 23 deletions(-)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_access_context_manager_service_perimeter_egress_policy" "primary" {
egress_from {
source_restriction = # value needed
sources {
access_level = # value needed
}
}
}
Resource: resource "google_access_context_manager_service_perimeters" "primary" {
service_perimeters {
spec {
egress_policies {
egress_from {
source_restriction = # value needed
sources {
access_level = # value needed
}
}
}
}
}
}
|
Tests analyticsTotal tests:
|
…anager_service_perimeter.tfplan.json
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 18 files changed, 1143 insertions(+), 23 deletions(-)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_access_context_manager_service_perimeter_egress_policy" "primary" {
egress_from {
source_restriction = # value needed
sources {
access_level = # value needed
}
}
}
Resource: resource "google_access_context_manager_service_perimeters" "primary" {
service_perimeters {
spec {
egress_policies {
egress_from {
source_restriction = # value needed
sources {
access_level = # value needed
}
}
}
}
}
}
|
Tests analyticsTotal tests: Action takenFound 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccDialogflowCXAgent_dialogflowcxAgentFullExample|TestAccDialogflowCXPage_dialogflowcxPageFullExample|TestAccDialogflowCXFlow_dialogflowcxFlowFullExample|TestAccDialogflowCXIntent_update|TestAccDialogflowCXAgent_update|TestAccDialogflowCXFlow_update|TestAccDialogflowCXPage_update |
Rerun these tests in REPLAYING mode to catch issues
|
…t_manager_service_perimeter.tf
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 18 files changed, 1143 insertions(+), 23 deletions(-)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_access_context_manager_service_perimeter_egress_policy" "primary" {
egress_from {
source_restriction = # value needed
sources {
access_level = # value needed
}
}
}
Resource: resource "google_access_context_manager_service_perimeters" "primary" {
service_perimeters {
spec {
egress_policies {
egress_from {
source_restriction = # value needed
sources {
access_level = # value needed
}
}
}
}
}
}
|
Tests analyticsTotal tests: Action takenFound 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccDialogflowCXAgent_dialogflowcxAgentFullExample|TestAccDialogflowCXFlow_dialogflowcxFlowFullExample|TestAccDialogflowCXPage_dialogflowcxPageFullExample|TestAccDialogflowCXAgent_update|TestAccDialogflowCXIntent_update|TestAccDialogflowCXFlow_update|TestAccDialogflowCXPage_update |
Rerun these tests in REPLAYING mode to catch issues
|
…n.json to make it parse correctly
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 18 files changed, 1143 insertions(+), 23 deletions(-)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_access_context_manager_service_perimeter_egress_policy" "primary" {
egress_from {
source_restriction = # value needed
sources {
access_level = # value needed
}
}
}
Resource: resource "google_access_context_manager_service_perimeters" "primary" {
service_perimeters {
spec {
egress_policies {
egress_from {
source_restriction = # value needed
sources {
access_level = # value needed
}
}
}
}
}
}
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 18 files changed, 1143 insertions(+), 23 deletions(-)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_access_context_manager_service_perimeter_egress_policy" "primary" {
egress_from {
source_restriction = # value needed
sources {
access_level = # value needed
}
}
}
Resource: resource "google_access_context_manager_service_perimeters" "primary" {
service_perimeters {
spec {
egress_policies {
egress_from {
source_restriction = # value needed
sources {
access_level = # value needed
}
}
}
}
}
}
|
Tests analyticsTotal tests: Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccBigQueryDataTable_bigtable |
Rerun these tests in REPLAYING mode to catch issues
|
…ce_perimeter.json
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 18 files changed, 1143 insertions(+), 23 deletions(-)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_access_context_manager_service_perimeter_egress_policy" "primary" {
egress_from {
source_restriction = # value needed
sources {
access_level = # value needed
}
}
}
Resource: resource "google_access_context_manager_service_perimeters" "primary" {
service_perimeters {
spec {
egress_policies {
egress_from {
source_restriction = # value needed
sources {
access_level = # value needed
}
}
}
}
}
}
|
Tests analyticsTotal tests:
|
…manager_service_perimeter.json
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 18 files changed, 1143 insertions(+), 23 deletions(-)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_access_context_manager_service_perimeter_egress_policy" "primary" {
egress_from {
source_restriction = # value needed
sources {
access_level = # value needed
}
}
}
Resource: resource "google_access_context_manager_service_perimeters" "primary" {
service_perimeters {
spec {
egress_policies {
egress_from {
source_restriction = # value needed
sources {
access_level = # value needed
}
}
}
}
}
}
|
Tests analyticsTotal tests: Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccDataSourceGoogleServiceAccountIdToken_impersonation|TestAccDataSourceGoogleServiceAccountJwt |
Rerun these tests in REPLAYING mode to catch issues
|
Similar PR as #8989, but with additional fixes in the Service Perimeters tests.
Moving changes for Access Context Manager's VPC Sub-segmentation feature from Terraform EAP to the normal provider.
Here is the PR that added these same fields to Terraform EAP.
Here are the new fields for Service Perimeters, so this PR adds these new fields (and associated sub-fields) to various Service Perimeter-related tests and resource files.
Similarly, here is the new field for Access Levels. This PR adds this new field (and associated sub-fields) to various Access Level-related tests and resource files.
Release Note Template for Downstream PRs (will be copied)