Vgm vpc subseg #9298

yifengli2023 · 2023-10-17T23:17:03Z

Similar PR as #8989, but with additional fixes in the Service Perimeters tests.

Moving changes for Access Context Manager's VPC Sub-segmentation feature from Terraform EAP to the normal provider.

Here is the PR that added these same fields to Terraform EAP.

Here are the new fields for Service Perimeters, so this PR adds these new fields (and associated sub-fields) to various Service Perimeter-related tests and resource files.

Similarly, here is the new field for Access Levels. This PR adds this new field (and associated sub-fields) to various Access Level-related tests and resource files.

Release Note Template for Downstream PRs (will be copied)

accesscontextmanager: added support for Access Context Manager's VPC Sub-segmentation feature

… and tests updated.

…moving a VPC network to the top level instead of (incorrectly) inside another resource.

… from the API returns. Also removing the 'resource' field because it's behind an allowlist.

modular-magician · 2023-10-17T23:18:48Z

Hello! I am a robot. It looks like you are a: ~~Community Contributor~~ Googler ~~Core Contributor~~. Tests will run automatically.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

modular-magician · 2023-10-17T23:27:20Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 18 files changed, 1143 insertions(+), 23 deletions(-))
Terraform Beta: Diff ( 18 files changed, 1143 insertions(+), 23 deletions(-))
TF Conversion: Diff ( 4 files changed, 302 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_access_context_manager_service_perimeter_egress_policy (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_access_context_manager_service_perimeter_egress_policy" "primary" {
  egress_from {
    source_restriction = # value needed
    sources {
      access_level = # value needed
    }
  }
}

Resource: google_access_context_manager_service_perimeters (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_access_context_manager_service_perimeters" "primary" {
  service_perimeters {
    spec {
      egress_policies {
        egress_from {
          source_restriction = # value needed
          sources {
            access_level = # value needed
          }
        }
      }
    }
  }
}

modular-magician · 2023-10-18T00:06:01Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 18 files changed, 1143 insertions(+), 23 deletions(-))
Terraform Beta: Diff ( 18 files changed, 1143 insertions(+), 23 deletions(-))
TF Conversion: Diff ( 4 files changed, 302 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_access_context_manager_service_perimeter_egress_policy (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_access_context_manager_service_perimeter_egress_policy" "primary" {
  egress_from {
    source_restriction = # value needed
    sources {
      access_level = # value needed
    }
  }
}

Resource: google_access_context_manager_service_perimeters (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_access_context_manager_service_perimeters" "primary" {
  service_perimeters {
    spec {
      egress_policies {
        egress_from {
          source_restriction = # value needed
          sources {
            access_level = # value needed
          }
        }
      }
    }
  }
}

modular-magician · 2023-10-18T01:20:36Z

Tests analytics

Total tests: 3153
Passed tests 2831
Skipped tests: 318
Affected tests: 4

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAccessContextManager|TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample|TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample|TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample

Get to know how VCR tests work

modular-magician · 2023-10-18T01:48:42Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccAccessContextManager[Debug log]
TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample[Debug log]
TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample[Debug log]
TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

slevenick

Just a couple changes needed based on the description of the fields not matching the function.

Other than that, looks good to me, thanks for adding tests!

mmv1/products/accesscontextmanager/AccessLevel.yaml

mmv1/products/accesscontextmanager/AccessLevelCondition.yaml

mmv1/products/accesscontextmanager/AccessLevels.yaml

match description.

modular-magician · 2023-10-18T18:59:22Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 18 files changed, 1143 insertions(+), 23 deletions(-))
Terraform Beta: Diff ( 18 files changed, 1143 insertions(+), 23 deletions(-))
TF Conversion: Diff ( 4 files changed, 302 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_access_context_manager_service_perimeter_egress_policy (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_access_context_manager_service_perimeter_egress_policy" "primary" {
  egress_from {
    source_restriction = # value needed
    sources {
      access_level = # value needed
    }
  }
}

Resource: google_access_context_manager_service_perimeters (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_access_context_manager_service_perimeters" "primary" {
  service_perimeters {
    spec {
      egress_policies {
        egress_from {
          source_restriction = # value needed
          sources {
            access_level = # value needed
          }
        }
      }
    }
  }
}

modular-magician · 2023-10-18T20:11:52Z

Tests analytics

Total tests: 3158
Passed tests 2840
Skipped tests: 318
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

…anager_service_perimeter.tfplan.json

modular-magician · 2023-10-19T19:49:06Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 18 files changed, 1143 insertions(+), 23 deletions(-))
Terraform Beta: Diff ( 18 files changed, 1143 insertions(+), 23 deletions(-))
TF Conversion: Diff ( 5 files changed, 331 insertions(+), 5 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_access_context_manager_service_perimeter_egress_policy (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_access_context_manager_service_perimeter_egress_policy" "primary" {
  egress_from {
    source_restriction = # value needed
    sources {
      access_level = # value needed
    }
  }
}

Resource: google_access_context_manager_service_perimeters (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_access_context_manager_service_perimeters" "primary" {
  service_perimeters {
    spec {
      egress_policies {
        egress_from {
          source_restriction = # value needed
          sources {
            access_level = # value needed
          }
        }
      }
    }
  }
}

modular-magician · 2023-10-19T21:00:22Z

Tests analytics

Total tests: 3163
Passed tests 2839
Skipped tests: 317
Affected tests: 7

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDialogflowCXAgent_dialogflowcxAgentFullExample|TestAccDialogflowCXPage_dialogflowcxPageFullExample|TestAccDialogflowCXFlow_dialogflowcxFlowFullExample|TestAccDialogflowCXIntent_update|TestAccDialogflowCXAgent_update|TestAccDialogflowCXFlow_update|TestAccDialogflowCXPage_update

Get to know how VCR tests work

modular-magician · 2023-10-19T21:13:37Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDialogflowCXAgent_dialogflowcxAgentFullExample[Debug log]
TestAccDialogflowCXPage_dialogflowcxPageFullExample[Debug log]
TestAccDialogflowCXFlow_dialogflowcxFlowFullExample[Debug log]
TestAccDialogflowCXIntent_update[Debug log]
TestAccDialogflowCXAgent_update[Debug log]
TestAccDialogflowCXFlow_update[Debug log]
TestAccDialogflowCXPage_update[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

…t_manager_service_perimeter.tf

modular-magician · 2023-10-19T21:28:37Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 18 files changed, 1143 insertions(+), 23 deletions(-))
Terraform Beta: Diff ( 18 files changed, 1143 insertions(+), 23 deletions(-))
TF Conversion: Diff ( 6 files changed, 335 insertions(+), 5 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_access_context_manager_service_perimeter_egress_policy (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_access_context_manager_service_perimeter_egress_policy" "primary" {
  egress_from {
    source_restriction = # value needed
    sources {
      access_level = # value needed
    }
  }
}

Resource: google_access_context_manager_service_perimeters (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_access_context_manager_service_perimeters" "primary" {
  service_perimeters {
    spec {
      egress_policies {
        egress_from {
          source_restriction = # value needed
          sources {
            access_level = # value needed
          }
        }
      }
    }
  }
}

modular-magician · 2023-10-19T22:39:27Z

Tests analytics

Total tests: 3163
Passed tests 2839
Skipped tests: 317
Affected tests: 7

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDialogflowCXAgent_dialogflowcxAgentFullExample|TestAccDialogflowCXFlow_dialogflowcxFlowFullExample|TestAccDialogflowCXPage_dialogflowcxPageFullExample|TestAccDialogflowCXAgent_update|TestAccDialogflowCXIntent_update|TestAccDialogflowCXFlow_update|TestAccDialogflowCXPage_update

Get to know how VCR tests work

modular-magician · 2023-10-19T22:52:31Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDialogflowCXAgent_dialogflowcxAgentFullExample[Debug log]
TestAccDialogflowCXFlow_dialogflowcxFlowFullExample[Debug log]
TestAccDialogflowCXPage_dialogflowcxPageFullExample[Debug log]
TestAccDialogflowCXAgent_update[Debug log]
TestAccDialogflowCXIntent_update[Debug log]
TestAccDialogflowCXFlow_update[Debug log]
TestAccDialogflowCXPage_update[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

…n.json to make it parse correctly

modular-magician · 2023-10-19T23:34:07Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 18 files changed, 1143 insertions(+), 23 deletions(-))
Terraform Beta: Diff ( 18 files changed, 1143 insertions(+), 23 deletions(-))
TF Conversion: Diff ( 6 files changed, 336 insertions(+), 4 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_access_context_manager_service_perimeter_egress_policy (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_access_context_manager_service_perimeter_egress_policy" "primary" {
  egress_from {
    source_restriction = # value needed
    sources {
      access_level = # value needed
    }
  }
}

Resource: google_access_context_manager_service_perimeters (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_access_context_manager_service_perimeters" "primary" {
  service_perimeters {
    spec {
      egress_policies {
        egress_from {
          source_restriction = # value needed
          sources {
            access_level = # value needed
          }
        }
      }
    }
  }
}

modular-magician · 2023-10-20T00:21:57Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 18 files changed, 1143 insertions(+), 23 deletions(-))
Terraform Beta: Diff ( 18 files changed, 1143 insertions(+), 23 deletions(-))
TF Conversion: Diff ( 7 files changed, 344 insertions(+), 5 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_access_context_manager_service_perimeter_egress_policy (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_access_context_manager_service_perimeter_egress_policy" "primary" {
  egress_from {
    source_restriction = # value needed
    sources {
      access_level = # value needed
    }
  }
}

Resource: google_access_context_manager_service_perimeters (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_access_context_manager_service_perimeters" "primary" {
  service_perimeters {
    spec {
      egress_policies {
        egress_from {
          source_restriction = # value needed
          sources {
            access_level = # value needed
          }
        }
      }
    }
  }
}

modular-magician · 2023-10-20T01:33:41Z

Tests analytics

Total tests: 3163
Passed tests 2845
Skipped tests: 317
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccBigQueryDataTable_bigtable

Get to know how VCR tests work

modular-magician · 2023-10-20T01:37:11Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccBigQueryDataTable_bigtable[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

…ce_perimeter.json

modular-magician · 2023-10-20T03:52:36Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 18 files changed, 1143 insertions(+), 23 deletions(-))
Terraform Beta: Diff ( 18 files changed, 1143 insertions(+), 23 deletions(-))
TF Conversion: Diff ( 7 files changed, 344 insertions(+), 5 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_access_context_manager_service_perimeter_egress_policy (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_access_context_manager_service_perimeter_egress_policy" "primary" {
  egress_from {
    source_restriction = # value needed
    sources {
      access_level = # value needed
    }
  }
}

Resource: google_access_context_manager_service_perimeters (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_access_context_manager_service_perimeters" "primary" {
  service_perimeters {
    spec {
      egress_policies {
        egress_from {
          source_restriction = # value needed
          sources {
            access_level = # value needed
          }
        }
      }
    }
  }
}

modular-magician · 2023-10-20T05:03:05Z

Tests analytics

Total tests: 3163
Passed tests 2846
Skipped tests: 317
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

…manager_service_perimeter.json

modular-magician · 2023-10-20T16:58:47Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 18 files changed, 1143 insertions(+), 23 deletions(-))
Terraform Beta: Diff ( 18 files changed, 1143 insertions(+), 23 deletions(-))
TF Conversion: Diff ( 7 files changed, 344 insertions(+), 5 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_access_context_manager_service_perimeter_egress_policy (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_access_context_manager_service_perimeter_egress_policy" "primary" {
  egress_from {
    source_restriction = # value needed
    sources {
      access_level = # value needed
    }
  }
}

Resource: google_access_context_manager_service_perimeters (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_access_context_manager_service_perimeters" "primary" {
  service_perimeters {
    spec {
      egress_policies {
        egress_from {
          source_restriction = # value needed
          sources {
            access_level = # value needed
          }
        }
      }
    }
  }
}

modular-magician · 2023-10-20T18:10:59Z

Tests analytics

Total tests: 3163
Passed tests 2844
Skipped tests: 317
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataSourceGoogleServiceAccountIdToken_impersonation|TestAccDataSourceGoogleServiceAccountJwt

Get to know how VCR tests work

modular-magician · 2023-10-20T18:15:27Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataSourceGoogleServiceAccountIdToken_impersonation[Debug log]
TestAccDataSourceGoogleServiceAccountJwt[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

vmoros and others added 17 commits September 18, 2023 11:32

First commit for VPC sub-segmentation feature. All relevant resources…

c5e5fbb

… and tests updated.

Merge branch 'GoogleCloudPlatform:main' into vgm_vpc_subseg

ceec9bc

Adding access levels instead of using a fake access level name. Also …

203cc96

…moving a VPC network to the top level instead of (incorrectly) inside another resource.

Fixing conflict between ip_subnetworks and vpc_ip_subnetworks

dc7c656

Undoing changes to access level condition test

b932cce

Undoing changes to access level condition test

1bf80fa

Ran gofmt

4345e60

Merge branch 'GoogleCloudPlatform:main' into vgm_vpc_subseg

6bea598

Re-adding access level conditions tests

134d0b2

Merge branch 'GoogleCloudPlatform:main' into vgm_vpc_subseg

c9c1592

Changing resource names to camel case to match what the HTTP response…

79ea7b9

… from the API returns. Also removing the 'resource' field because it's behind an allowlist.

Parameterizing the names of VPC networks created in tests

a52ee0d

Merge branch 'main' into vgm_vpc_subseg

6c4a2d6

Fixing access level condition test

ad1898f

Merge branch 'GoogleCloudPlatform:main' into vgm_vpc_subseg

0752940

Fixed formatting with gofmt

26e6d76

Added missing fields in egress_from for service perimeter test.

582b038

modular-magician requested a review from slevenick October 17, 2023 23:18

Merge branch 'GoogleCloudPlatform:main' into vgm_vpc_subseg

a77f51b

slevenick requested changes Oct 18, 2023

View reviewed changes

mmv1/products/accesscontextmanager/AccessLevel.yaml Show resolved Hide resolved

mmv1/products/accesscontextmanager/AccessLevelCondition.yaml Show resolved Hide resolved

mmv1/products/accesscontextmanager/AccessLevels.yaml Show resolved Hide resolved

yifengli2023 and others added 2 commits October 18, 2023 11:47

Added "required: true" for AccessLevel.VpcNetworkSource.network field to

d870bb6

match description.

Merge branch 'GoogleCloudPlatform:main' into vgm_vpc_subseg

61f7ea0

modular-magician requested a review from slevenick October 18, 2023 18:49

Added egress source changes to test data in: example_access_context_m…

0f5ad72

…anager_service_perimeter.tfplan.json

Add Egress Source/source restriction changes to example_access_contex…

2dc709c

…t_manager_service_perimeter.tf

Attempt to fix example_access_context_manager_service_perimeter.tfpla…

1fe01cd

…n.json to make it parse correctly

Add Egress Source to expected tcg test result data

bf26306

Fixing expected output format in example_access_context_manager_servi…

4724854

…ce_perimeter.json

Fix Access Level format in expected output in example_access_context_…

73f1872

…manager_service_perimeter.json

slevenick approved these changes Oct 20, 2023

View reviewed changes

slevenick merged commit d30384c into GoogleCloudPlatform:main Oct 20, 2023
14 checks passed

This was referenced Oct 20, 2023

Vgm vpc subseg hashicorp/terraform-provider-google-beta#6553

Merged

Vgm vpc subseg hashicorp/terraform-provider-google#16327

Merged

Vgm vpc subseg GoogleCloudPlatform/terraform-google-conversion#1627

Merged

SarahFrench mentioned this pull request May 29, 2024

Adding support for Access Context Manager's VPC Sub-segmentation feature #8989

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Vgm vpc subseg #9298

Vgm vpc subseg #9298

yifengli2023 commented Oct 17, 2023 •

edited by slevenick

Loading

modular-magician commented Oct 17, 2023

modular-magician commented Oct 17, 2023

modular-magician commented Oct 18, 2023

modular-magician commented Oct 18, 2023

modular-magician commented Oct 18, 2023

slevenick left a comment

modular-magician commented Oct 18, 2023

modular-magician commented Oct 18, 2023

modular-magician commented Oct 19, 2023

modular-magician commented Oct 19, 2023

modular-magician commented Oct 19, 2023

modular-magician commented Oct 19, 2023

modular-magician commented Oct 19, 2023

modular-magician commented Oct 19, 2023

modular-magician commented Oct 19, 2023

modular-magician commented Oct 20, 2023

modular-magician commented Oct 20, 2023

modular-magician commented Oct 20, 2023

modular-magician commented Oct 20, 2023

modular-magician commented Oct 20, 2023

modular-magician commented Oct 20, 2023

modular-magician commented Oct 20, 2023

modular-magician commented Oct 20, 2023

Vgm vpc subseg #9298

Vgm vpc subseg #9298

Conversation

yifengli2023 commented Oct 17, 2023 • edited by slevenick Loading

modular-magician commented Oct 17, 2023

modular-magician commented Oct 17, 2023

Diff report

Missing test report

modular-magician commented Oct 18, 2023

Diff report

Missing test report

modular-magician commented Oct 18, 2023

Tests analytics

Action taken

modular-magician commented Oct 18, 2023

Rerun these tests in REPLAYING mode to catch issues

slevenick left a comment

Choose a reason for hiding this comment

modular-magician commented Oct 18, 2023

Diff report

Missing test report

modular-magician commented Oct 18, 2023

Tests analytics

modular-magician commented Oct 19, 2023

Diff report

Missing test report

modular-magician commented Oct 19, 2023

Tests analytics

Action taken

modular-magician commented Oct 19, 2023

Rerun these tests in REPLAYING mode to catch issues

modular-magician commented Oct 19, 2023

Diff report

Missing test report

modular-magician commented Oct 19, 2023

Tests analytics

Action taken

modular-magician commented Oct 19, 2023

Rerun these tests in REPLAYING mode to catch issues

modular-magician commented Oct 19, 2023

Diff report

Missing test report

modular-magician commented Oct 20, 2023

Diff report

Missing test report

modular-magician commented Oct 20, 2023

Tests analytics

Action taken

modular-magician commented Oct 20, 2023

Rerun these tests in REPLAYING mode to catch issues

modular-magician commented Oct 20, 2023

Diff report

Missing test report

modular-magician commented Oct 20, 2023

Tests analytics

modular-magician commented Oct 20, 2023

Diff report

Missing test report

modular-magician commented Oct 20, 2023

Tests analytics

Action taken

modular-magician commented Oct 20, 2023

Rerun these tests in REPLAYING mode to catch issues

yifengli2023 commented Oct 17, 2023 •

edited by slevenick

Loading