-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: serialize AST to json #94
Conversation
Codecov ReportAttention: Patch coverage is
Changes have been made to critical files, which contain lines commonly executed in production. Learn more
Additional details and impacted files@@ Coverage Diff @@
## main #94 +/- ##
==========================================
- Coverage 98.98% 98.97% -0.01%
==========================================
Files 14 14
Lines 6320 6467 +147
==========================================
+ Hits 6256 6401 +145
- Misses 64 66 +2 ☔ View full report in Codecov by Sentry. |
Please let me know if there are promql statements have:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Others LGTM. I wonder if we should make some functions pub(crate)
only.
Sounds good. We should keep minimal access. |
AFAIK, subquery is a range query that doesn't accept a null step. And existing functions don't have variadic param list |
Fixes #93
This patch attempts to add AST serialization to match output of prometheus 3.0 parse_query.