Sync develop changes to hdf5_1_14 #4911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ibhdf5_hl_fortran. (HDFGroup#4831) * Change name of libhdf5hl_fortran installed by autotools to libhdf5_hl_fortran to be consistent with CMake install and with other hl lib files. Switched corresponding symlink to libhdf5hl_fortran. Fixes issue HDFGroup#4684. * Update h5fc.in to use renamed libhdf5_hl_fortran. Fix typo in code to create link to libhdf5_hl_fortran.a. * Removed code to create symlink for previous name of renamed lib libhdf5hl_fortran. Add RELEASE.txt entry about changeing name libhdf5hl_fortran to libhdf5_hl_fortran. * Update missed line in h5fc.in for libhdf5hl_fortran name change to libhdf5_hl_fortran. Fixes check-install failure.
* Fixes a segfault in h5dump The B-tree node level was corrupted, resulting in a segfault later. This PR adds a check to detect when the node level is greater than the number of entries and issue an error instead. Fixes HDFGroupGH-4432
H5LTfind_dataset() returns true for non-existing datasets because it only compares up to the length of the searched string, such as "Day" vs "DayNight" (issue HDFGroupGH-4780). This PR applied the user's patch and added tests.
In H5F__accum_reset(), when H5F__accum_flush() failed, the freeing of f_sh->accum.buf was never reached, causing resource leak. @fortnern added the third argument to H5F__accum_reset() so we can free f_sh->accum.buf when we close the file, that is, when H5F__accum_reset() is called from the H5F__dest() route, and can leave the accumulator in place otherwise.
* Add filebase info
…roup#4891) Added new testframe.h header to document testing framework functions and split them away from h5test.h and from test programs that don't integrate with the testframe.c testing framework Added new test setup callback to testframe.c testing framework Added parameters to AddTest() to specify size of test parameters so they can be copied for later use Enabled HDF5 error stacks in testframe.c framework by default and added some error stack suppressions to some testhdf5 tests Added new maxthreads option to testframe.c framework to allow specifying the maximum number of threads a multi-threaded test can use Moved TestExpress functionality out of testframe.c and into more general h5test.c for wider use by tests through getter and setter Updated some tests to not mix and match functionality between h5test.c/h and testframe.c/h Moved some functionality from testphdf5.h into testpar.h for parallel tests that aren't part of testphdf5 Added new parallel test library that contains common shared functionality for parallel tests (similar to h5test library)
lrknox
requested review from
brtnfld,
derobins,
epourmal,
byrnHDF,
fortnern,
jhendersonHDF,
qkoziol,
vchoi-hdfgroup and
bmribler
as code owners
byrnHDF
reviewed
Oct 2, 2024
.github/workflows/hdfeos5.yml
Outdated
| @@ -0,0 +1,51 @@ | |||
| name: hdfeos5 dev | |||
byrnHDF
reviewed
Oct 2, 2024
.github/workflows/hdfeos5.yml
Outdated
| workflow_dispatch: | ||
| push: | ||
| pull_request: | ||
| branches: [ develop ] |
byrnHDF
reviewed
Oct 2, 2024
| @@ -98,7 +98,15 @@ New Features | |||
|
|
|||
| Documentation: | |||
| -------------- | |||
| - | |||
| - Documented that leaving HDF5 threads running at termination is unsafe | |||
There was a problem hiding this comment.
Did this not get into 1.14.5?
lrknox
commented
Oct 2, 2024
.github/workflows/hdfeos5.yml
Outdated
| @@ -0,0 +1,51 @@ | |||
| name: hdfeos5 dev | |||
There was a problem hiding this comment.
name: hdfeos5 1.14
Suggested change
| name: hdfeos5 dev | |
| name: hdfeos5 dev |
lrknox
commented
Oct 2, 2024
lrknox
commented
Oct 2, 2024
byrnHDF
approved these changes
Oct 2, 2024
jhendersonHDF
added
Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.