Merge from upstream #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adding .netlify folder to .gitignore * Bump the Netlify function dependencies upstair
Fixes #51
* Make updating the test "should have script elements" easier * Make reading minutes always >= 1.
#54) * Prevent duplicate link rel prefetches and prevent prefetching the current page. Add two checks against the prospective href to prefetch: 1. Has the href already been prefetched? 2. Is the href equal to the current page? There is not a benefit to duplicate prefetches or prefetching the current page. If either check is true, return without prefetching the href. * Remove unnecessary check for duplicate fetches as prefetch cache should already account for this. * Include query string in the URL comparison (exclude the fragment). Co-authored-by: nickFalcone <nfalcone@u.rochester.edu>
The variable font was only set on the html element, while the body and certain other elmeents always had the static fonts applied. This resulted in the static fonts always getting loaded, even if the browser supports variable fonts.
Related to #57
This is needed because we throw away the metadata during resizing.
…ror. (#63) The error was reported at cdeleeuwe/netlify-plugin-submit-sitemap#18. Since Netlify is also a growing service for hosting static sites, this will save people a lot of time debugging.
* Add Core Web Vitals UMD library and include in base.njk * Send GA event with data for CLS, FID, and LCP. * Add license and attribution info. * Add flag to control sending web vitals data to GA * Add module to check web vital opt-in and that library exists * Web vitals script is dependent on GA - move inside check for GA * Update test to account for potential web vitals script * Fix small typo * Indent to show nesting * Mention sending CWV to GA * Move function to send CWV metrics to web-vitals.js * Check for web vitals library independently of user opt-in * Remove function to send CWV metrtics. Make web vitals library independent of GA * Send CWV metrics to GA from main.js * Remove console log * Check web vitals library separately from GA * Return early if user opts-out of sending CWV * Create function to inject script. Inject CWV script if user opts-in to sending metrics * Remove web-vitals.js and inject if user opts-in. Add attribute to body to check opt-in * Revert back to original script test as web-vitals may be injected dynamically * Send web vitals off by default * Simplify and just return metadata.sendWebVitals. * Ignore error case * Check data-cwv-src attribute of current script for web-vitals.js * Move data-cwv-src attribute from body to script, add hash.
Bumps [ini](https://github.com/isaacs/ini) from 1.3.5 to 1.3.8. - [Release notes](https://github.com/isaacs/ini/releases) - [Commits](npm/ini@v1.3.5...v1.3.8) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [pug-code-gen](https://github.com/pugjs/pug) from 2.0.2 to 2.0.3. - [Release notes](https://github.com/pugjs/pug/releases) - [Commits](https://github.com/pugjs/pug/compare/pug-code-gen@2.0.2...pug@2.0.3) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [y18n](https://github.com/yargs/y18n) from 4.0.0 to 4.0.1. - [Release notes](https://github.com/yargs/y18n/releases) - [Changelog](https://github.com/yargs/y18n/blob/master/CHANGELOG.md) - [Commits](https://github.com/yargs/y18n/commits) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.20 to 4.17.21. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.20...4.17.21) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [hosted-git-info](https://github.com/npm/hosted-git-info) from 2.8.8 to 2.8.9. - [Release notes](https://github.com/npm/hosted-git-info/releases) - [Changelog](https://github.com/npm/hosted-git-info/blob/v2.8.9/CHANGELOG.md) - [Commits](npm/hosted-git-info@v2.8.8...v2.8.9) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [ws](https://github.com/websockets/ws) from 7.3.0 to 7.4.6. - [Release notes](https://github.com/websockets/ws/releases) - [Commits](websockets/ws@7.3.0...7.4.6) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
When a post has `permalink` set to false, though no output file is generated, the file is still processed with the `url` property set to false. Thus, the expression in base.njk testing the `url` property must ensure page.url is defined in advance.
Bumps [prismjs](https://github.com/PrismJS/prism) from 1.23.0 to 1.24.0. - [Release notes](https://github.com/PrismJS/prism/releases) - [Changelog](https://github.com/PrismJS/prism/blob/master/CHANGELOG.md) - [Commits](PrismJS/prism@v1.23.0...v1.24.0) --- updated-dependencies: - dependency-name: prismjs dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.