Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set Language (Changing language not working bug) #34

Closed
sitton76 opened this issue Mar 23, 2022 · 6 comments
Closed

Set Language (Changing language not working bug) #34

sitton76 opened this issue Mar 23, 2022 · 6 comments
Labels
bug Something isn't working

Comments

@sitton76
Copy link

Hi, I was trying to help someone out who wanted the game to be in German, I knew that game has a debug function to set it to French, English, or German so I attempted to help, however I was having trouble getting the game to accept the inputs(as they needed to be entered from the 3rd controllers input) and at one point was able to set it to French but was unable to replicate it.

Anyways the main reason im making this post here is that it would be great if instead of having to set this from the debug functions if it could be entered from the SoH console instead.
@MegaMech MegaMech changed the title Console command for setting language(suggestion) [cvar] set language Mar 23, 2022
@MegaMech MegaMech changed the title [cvar] set language Set Language Mar 24, 2022
@MegaMech MegaMech added the cvar label Mar 24, 2022
@MegaMech
Copy link
Contributor

Apparently you can change the language using debug controller button combinations.

@Reshiban
Copy link

Apparently you can change the language using debug controller button combinations.

Hi !
I suggest to add a way to "force" a language from the .ini config.
Also I switched the game from english to french by editing the savefile (3rd Byte from 00 to 02), but only menus are working, no dialog is appearing (was working in english).

image

@MegaMech
Copy link
Contributor

How this is done is up to whoever implements it.

It sounds like you can change language on the fly in-game. As such, I think cvar or imGUI option makes more sense then having users edit .ini other than to save what language a person chose.

@Reshiban
Copy link

Reshiban commented Mar 25, 2022 •
edited
Loading

Forget the .ini idea, that's not a very good one yes.

The main reason why I reply is due to an issue. When you load the game in french/german instead of eng (that are included in the debug ROM) menus are loading properly, but no character dialog is shown at all which is problematic and cause sometimes a softlock :p

I tested on the modified & unmodified ROMs with N64 emulator, and PNJs are talking without problem. So this mean there is probably an issue in the PC port itself. I implore you to check it please 🙏

@MegaMech MegaMech changed the title Set Language Set Language (Changing language not working bug) Mar 25, 2022
@MegaMech MegaMech added the bug Something isn't working label Mar 25, 2022
@jbodner09
Copy link
Contributor

I suspect your issue is just because the devs never implemented the other two languages. Looking at the code in https://github.com/HarbourMasters/Shipwright/blob/develop/soh/src/code/z_message_PAL.c, the language selection for non-English languages is commented out. I'd bet if you looked at the console, you'd see a bunch of "Message not found" errors.

MelonSpeedruns pushed a commit to MelonSpeedruns/Shipwright that referenced this issue Mar 31, 2022
@NEstelami
Merge pull request HarbourMasters#34 from KiritoDv/master
f45f939 
Moved cvars to C++
@PurpleHato
Copy link
Member

Feature added for Roy Alfa, closing issue

MelonSpeedruns pushed a commit to MelonSpeedruns/Shipwright that referenced this issue Jun 1, 2022
@briaguya-ai
Merge pull request HarbourMasters#34 from briaguya-ai/rolling-gorons
485af21 
rolling gorons
Kenix3 pushed a commit that referenced this issue Apr 26, 2023
@NEstelami
Fixed issues with ganon cape (#34)
f76fdd0
briaguya-ai added a commit that referenced this issue Apr 27, 2023
@briaguya-ai @NEstelami
@dcvz @Kenix3 @KiritoDv @stratomaster64 @MelonSpeedruns @Archez @inspectredc @Patrick12115 @Rozelette @leggettc18
spockalicious (#2751)
4166dbf 
* Rough mockup of LUS XML loading

* Updated code for merge

* Loading from FS support and custom DList WIP implementation

* Added current directory support to F3D and impl most of the dlist cmds

* WIP Skeleton support

* Almost done

* Rebase fixes

* Submodule updates

* HD Texture Support

* Fixes

* bump lus

* fix exporter build, header update

* soh builds

* setMesh image path cleanup

* Update soh/src/overlays/actors/ovl_player_actor/z_player.c

* Update soh/src/overlays/actors/ovl_player_actor/z_player.c

* Update OTRExporter/OTRExporter/Main.cpp

* Update ZAPDTR/ZAPD/ZResource.h

* Update soh/src/code/z_skelanime.c

* Update OTRExporter/OTRExporter/Main.cpp

* Fixed jpeg backgrounds and decreased icon buffer size

* Bump lus

* Increased even more the buffer because it crashes on long texts

* Removed print because sometimes the if is not triggered when the image is already byteswapped

* fix non-windows build

* fix build

Co-authored-by: Kenix <kenixwhisperwind@gmail.com>

* add hd checkbox

* Various fixes for custom model support (#23)

* Some fixes

* Updated LUS Version

* Fixed issue with Link Skirt on pause menu

* Added CVar for custom link model changes

* Fixed headers

* Additional header fixes

* Tweaks

* Unload HD game assets on scene transition. (#16)

* Unload game assets on scene transition.

* Bump LUS

* Unloads all HD assets on scene transition.

* Only unload hd assets if hd assets are turned on.

* Fixes issues on toggling between HD and non HD assets.

---------

Co-authored-by: briaguya <briaguya@alice>

* fix: actually load hd debug font (#27)

* fix: actually load hd debug font

* toggle debug text correctly

---------

Co-authored-by: briaguya <briaguya>

* Yes. (#28)

* Merge branch 'develop' into dev-to-ghost

* HD Skeleton Swapping and Language Fixes (#32)

* Yes.

* HD Skeleton Swapping and Language Fixes

* Test

* Fixed issues with ganon cape (#34)

* Fixed Bongo Bongo Crash (#35)

* Added HD Assets Toggle (#37)

* Ivan the Fairy - Coop Mode (#36)

* wip

* hookshotable ivan

* added hookshot item

* new items & changes & fixes & restored navi

* farore, din and nayru's spells are done

* fixed slingshot & bow

* added more items supported

* done with all main items

* bug fixes & ready

* added imgui button

* wip

* hookshotable ivan

* added hookshot item

* new items & changes & fixes & restored navi

* farore, din and nayru's spells are done

* fixed slingshot & bow

* added more items supported

* fix own dungeon items on shuffled boss rooms (#2683)

* bump lus (#2692)

* fix: lowercase package names for vcpkg (#2693)

vcpkg was throwing an error `error: invalid character in package name (must be lowercase, digits, '-')`
this updates our calls to `vcpkg_install_packages` to use lowercase package names instead of uppercase

* fix death mountain cloud in rando (#2691)

* Fix: Switch Age No Longer Reloads Start Room (#2679)

* [Reduced Clutter] Disable Hot/Underwater Warning Text (#2684)

* Disable Warning Text

* Moved to Reduced Clutter

* done with all main items

* bug fixes & ready

* fix: process roms in consistent order (#2696)

* chore: move rando savefile setup and document flags (#2697)

* remove rando save init from sram

* move rando savefile init logic and set more flags

* document flags for rando save creation

* Fix: Use correct fps value for frame interpolation with match refresh rate (#2694)

* Fix: Kak GS placement on construction site (#2695)

* added imgui button

* addressed kenix's comments

* fixed useless null

* added rupee dash mode in extra modes

* changed menu position

---------

Co-authored-by: Adam Bird <Archez@users.noreply.github.com>
Co-authored-by: briaguya <70942617+briaguya-ai@users.noreply.github.com>
Co-authored-by: inspectredc <78732756+inspectredc@users.noreply.github.com>
Co-authored-by: Patrick12115 <115201185+Patrick12115@users.noreply.github.com>

* LUS Scancodes (#42)

* Added HD Assets Toggle

* Switched out SDL for LUS scancodes

* Ivan tweaks (#45)

* Magic consumption slowed down;
Bosses now affected by Ivan's Din spell

* Adjust magic timer

* clean up imgui

* model fixes/improvements (#50)

* replace `gUseCustomLinkModel` with custom resource check

* handle adult/child

* bump lus

* fix model switching with tab

* use lus main

* fix carpet man (#52)

Co-authored-by: Rozelette <Rozelette@users.noreply.github.com>

* get ship model and lus texture into soh.otr, use `gAuthenticLogo` to toggle between ship and authentic (#55)

* Use libultra features for CPU-modified textures (#40)

* Use libultra features for CPU-modified textures

* Comment

* bump lus on ghost (#58)

* fix: properly use `Interface_LoadActionLabel` to display start button text (#61)

* Changes hd -> alt for texture replacement. (#65)

* Changes hd -> alt for texture replacement.

* Renames variables in gfxprint for hd -> alt change.

* Update soh/soh/resource/type/Skeleton.cpp

---------

Co-authored-by: briaguya <70942617+briaguya-ai@users.noreply.github.com>

* Fixes kaleido dungeon maps (#67)

* skeleton stuff (#69)

* comment out wii u build (#70)

* bump lus (#71)

* Rework readme (#72)

* Update README.md

* docs

* put custom music docs somewhere

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* dark/light title image

* lus

* Update README.md

* Fixed vanilla minimap (#73)

* Fixed vanilla minimap

* Workaround for pulsing SD maps with non-broken HD maps.

---------

Co-authored-by: Christopher Leggett <chris@leggett.dev>

* Skeleton fix fixed (#75)

* WIP skelton patcher fix

* Fixes skeleton reference change.

* Adds const back to name in ResourceMgr_LoadSkeletonByName

---------

Co-authored-by: Christopher Leggett <chris@leggett.dev>
Co-authored-by: Kenix <kenixwhisperwind@gmail.com>

* Fixes z_message_otr memory leak.

* Update soh/soh/z_message_OTR.cpp

* Update soh/src/code/game.c

* docs: add how to find otr files to switch instructions (#78)

* bump lus (#79)

* comment out RegisterBlendedTexture in king d (#80)

---------

Co-authored-by: Nicholas Estelami <NEstelami@users.noreply.github.com>
Co-authored-by: David Chavez <david@dcvz.io>
Co-authored-by: briaguya <briaguya@alice>
Co-authored-by: Kenix3 <kenixwhisperwind@gmail.com>
Co-authored-by: KiritoDv <kiritodev01@gmail.com>
Co-authored-by: briaguya <briaguya>
Co-authored-by: Ralphie Morell <stratomaster64@gmail.com>
Co-authored-by: MelonSpeedruns <melonspeedruns@outlook.com>
Co-authored-by: Adam Bird <Archez@users.noreply.github.com>
Co-authored-by: inspectredc <78732756+inspectredc@users.noreply.github.com>
Co-authored-by: Patrick12115 <115201185+Patrick12115@users.noreply.github.com>
Co-authored-by: Rozelette <Rozelette@users.noreply.github.com>
Co-authored-by: Christopher Leggett <chris@leggett.dev>
Co-authored-by: Lywx <36680385+KiritoDv@users.noreply.github.com>
Caladius referenced this issue in Caladius/Shipwright Aug 29, 2024
@aMannus
Merge pull request #34 from Caladius/potsanity_v1
fe9e1e0 
Vanilla Drop List
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@MegaMech @Reshiban @jbodner09 @PurpleHato @sitton76