Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Goron Get Up Animation Is Slightly Bugged #80

Closed
ghost opened this issue Mar 24, 2022 · 5 comments
Closed

Goron Get Up Animation Is Slightly Bugged #80

ghost opened this issue Mar 24, 2022 · 5 comments
Assignees
@leggettc18
Labels
bug Something isn't working
Milestone
Zhora Bravo/Charl...

Comments

@ghost
Copy link

ghost commented Mar 24, 2022

When approaching a goron while they're crouched, instead of raising their head, their model rotates counterclockwise.
The rest of the animation works properly.

Playing on default settings with sdl backend and the LOD removal enhancement.
running the game on windows10 with an intel processor and nvidia gpu

2022-03-24.12-12-37.mp4
@xoniq
Copy link

xoniq commented Mar 24, 2022

He was just spooked so got up real fast 😂

@MegaMech MegaMech added the bug Something isn't working label Mar 24, 2022
MelonSpeedruns pushed a commit to MelonSpeedruns/Shipwright that referenced this issue Jun 8, 2022
@briaguya-ai
Merge pull request HarbourMasters#80 from briaguya-ai/more-settings
c1478fd 
forgot a file
@Kenix3 Kenix3 added this to the 4.0.0 milestone Jul 12, 2022
@leggettc18 leggettc18 self-assigned this Jul 22, 2022
@leggettc18 leggettc18 mentioned this issue Jul 23, 2022
Merged
@Kenix3 Kenix3 reopened this Aug 2, 2022
@garrettjoecox
Copy link
Contributor

Is this still an issue?

@leggettc18
Copy link
Contributor

Yeah. This is one of those things where I'm not exactly sure where the issue is. I thought I had fixed it once but it broke something else so we had to revert.

@NitrousTheIceFox
Copy link

NitrousTheIceFox commented Oct 1, 2022 •
edited
Loading

If this does get fixed again, can there be an option for it to be unfixed? I think it's quite humorous how they seem to do a Star Fox Barrel Roll. The community also seems pretty fond of it; a friend told me that ZFG in one of his last videos said "Please never fix the get up animation." or something along those lines. 😄

garrettjoecox referenced this issue in garrettjoecox/OOT Oct 9, 2022
@garrettjoecox
[#80] Fix for goron spin on wake up animation
f0fc186
dcvz pushed a commit that referenced this issue Oct 10, 2022
@garrettjoecox
[#80] Fix for goron spin on wake up animation (#1714)
14543d5
@aMannus
Copy link
Contributor

aMannus commented Oct 10, 2022

Resolved by #1714

@aMannus aMannus closed this as completed Oct 10, 2022
mergify bot pushed a commit that referenced this issue Oct 11, 2022
@garrettjoecox @mergify
[#80] Fix for goron spin on wake up animation (#1714)
1f9c277 
(cherry picked from commit 14543d5)
dcvz pushed a commit that referenced this issue Oct 11, 2022
@mergify
[#80] Fix for goron spin on wake up animation (#1714) (#1746)
83541f4
Kenix3 pushed a commit to Kenix3/Shipwright that referenced this issue Oct 19, 2022
@garrettjoecox @Kenix3
[HarbourMasters#80] Fix for goron spin on wake up animation (HarbourM…
ccde658 
…asters#1714)
leggettc18 pushed a commit to leggettc18/Shipwright that referenced this issue Oct 19, 2022
@garrettjoecox @leggettc18
[HarbourMasters#80] Fix for goron spin on wake up animation (HarbourM…
ecfbef8 
…asters#1714)
leggettc18 pushed a commit to leggettc18/Shipwright that referenced this issue Oct 19, 2022
@garrettjoecox @leggettc18
[HarbourMasters#80] Fix for goron spin on wake up animation (HarbourM…
46a3a56 
…asters#1714)
th-2021 pushed a commit to th-2021/Shipwright-cmake that referenced this issue Nov 28, 2022
@garrettjoecox @th-2021
[HarbourMasters#80] Fix for goron spin on wake up animation (HarbourM…
ae643d7 
…asters#1714)
th-2021 pushed a commit to th-2021/Shipwright-cmake that referenced this issue Nov 28, 2022
@garrettjoecox @th-2021
[HarbourMasters#80] Fix for goron spin on wake up animation (HarbourM…
fe47a67 
…asters#1714)
th-2021 pushed a commit to th-2021/Shipwright-cmake that referenced this issue Nov 28, 2022
@garrettjoecox @th-2021
[HarbourMasters#80] Fix for goron spin on wake up animation (HarbourM…
03b8087 
…asters#1714)
th-2021 pushed a commit to th-2021/Shipwright-cmake that referenced this issue Nov 28, 2022
@garrettjoecox @th-2021
[HarbourMasters#80] Fix for goron spin on wake up animation (HarbourM…
afda474 
…asters#1714)
briaguya-ai added a commit that referenced this issue Apr 27, 2023
@briaguya-ai
comment out RegisterBlendedTexture in king d (#80)
e516abe
briaguya-ai added a commit that referenced this issue Apr 27, 2023
@briaguya-ai @NEstelami
@dcvz @Kenix3 @KiritoDv @stratomaster64 @MelonSpeedruns @Archez @inspectredc @Patrick12115 @Rozelette @leggettc18
spockalicious (#2751)
4166dbf 
* Rough mockup of LUS XML loading

* Updated code for merge

* Loading from FS support and custom DList WIP implementation

* Added current directory support to F3D and impl most of the dlist cmds

* WIP Skeleton support

* Almost done

* Rebase fixes

* Submodule updates

* HD Texture Support

* Fixes

* bump lus

* fix exporter build, header update

* soh builds

* setMesh image path cleanup

* Update soh/src/overlays/actors/ovl_player_actor/z_player.c

* Update soh/src/overlays/actors/ovl_player_actor/z_player.c

* Update OTRExporter/OTRExporter/Main.cpp

* Update ZAPDTR/ZAPD/ZResource.h

* Update soh/src/code/z_skelanime.c

* Update OTRExporter/OTRExporter/Main.cpp

* Fixed jpeg backgrounds and decreased icon buffer size

* Bump lus

* Increased even more the buffer because it crashes on long texts

* Removed print because sometimes the if is not triggered when the image is already byteswapped

* fix non-windows build

* fix build

Co-authored-by: Kenix <kenixwhisperwind@gmail.com>

* add hd checkbox

* Various fixes for custom model support (#23)

* Some fixes

* Updated LUS Version

* Fixed issue with Link Skirt on pause menu

* Added CVar for custom link model changes

* Fixed headers

* Additional header fixes

* Tweaks

* Unload HD game assets on scene transition. (#16)

* Unload game assets on scene transition.

* Bump LUS

* Unloads all HD assets on scene transition.

* Only unload hd assets if hd assets are turned on.

* Fixes issues on toggling between HD and non HD assets.

---------

Co-authored-by: briaguya <briaguya@alice>

* fix: actually load hd debug font (#27)

* fix: actually load hd debug font

* toggle debug text correctly

---------

Co-authored-by: briaguya <briaguya>

* Yes. (#28)

* Merge branch 'develop' into dev-to-ghost

* HD Skeleton Swapping and Language Fixes (#32)

* Yes.

* HD Skeleton Swapping and Language Fixes

* Test

* Fixed issues with ganon cape (#34)

* Fixed Bongo Bongo Crash (#35)

* Added HD Assets Toggle (#37)

* Ivan the Fairy - Coop Mode (#36)

* wip

* hookshotable ivan

* added hookshot item

* new items & changes & fixes & restored navi

* farore, din and nayru's spells are done

* fixed slingshot & bow

* added more items supported

* done with all main items

* bug fixes & ready

* added imgui button

* wip

* hookshotable ivan

* added hookshot item

* new items & changes & fixes & restored navi

* farore, din and nayru's spells are done

* fixed slingshot & bow

* added more items supported

* fix own dungeon items on shuffled boss rooms (#2683)

* bump lus (#2692)

* fix: lowercase package names for vcpkg (#2693)

vcpkg was throwing an error `error: invalid character in package name (must be lowercase, digits, '-')`
this updates our calls to `vcpkg_install_packages` to use lowercase package names instead of uppercase

* fix death mountain cloud in rando (#2691)

* Fix: Switch Age No Longer Reloads Start Room (#2679)

* [Reduced Clutter] Disable Hot/Underwater Warning Text (#2684)

* Disable Warning Text

* Moved to Reduced Clutter

* done with all main items

* bug fixes & ready

* fix: process roms in consistent order (#2696)

* chore: move rando savefile setup and document flags (#2697)

* remove rando save init from sram

* move rando savefile init logic and set more flags

* document flags for rando save creation

* Fix: Use correct fps value for frame interpolation with match refresh rate (#2694)

* Fix: Kak GS placement on construction site (#2695)

* added imgui button

* addressed kenix's comments

* fixed useless null

* added rupee dash mode in extra modes

* changed menu position

---------

Co-authored-by: Adam Bird <Archez@users.noreply.github.com>
Co-authored-by: briaguya <70942617+briaguya-ai@users.noreply.github.com>
Co-authored-by: inspectredc <78732756+inspectredc@users.noreply.github.com>
Co-authored-by: Patrick12115 <115201185+Patrick12115@users.noreply.github.com>

* LUS Scancodes (#42)

* Added HD Assets Toggle

* Switched out SDL for LUS scancodes

* Ivan tweaks (#45)

* Magic consumption slowed down;
Bosses now affected by Ivan's Din spell

* Adjust magic timer

* clean up imgui

* model fixes/improvements (#50)

* replace `gUseCustomLinkModel` with custom resource check

* handle adult/child

* bump lus

* fix model switching with tab

* use lus main

* fix carpet man (#52)

Co-authored-by: Rozelette <Rozelette@users.noreply.github.com>

* get ship model and lus texture into soh.otr, use `gAuthenticLogo` to toggle between ship and authentic (#55)

* Use libultra features for CPU-modified textures (#40)

* Use libultra features for CPU-modified textures

* Comment

* bump lus on ghost (#58)

* fix: properly use `Interface_LoadActionLabel` to display start button text (#61)

* Changes hd -> alt for texture replacement. (#65)

* Changes hd -> alt for texture replacement.

* Renames variables in gfxprint for hd -> alt change.

* Update soh/soh/resource/type/Skeleton.cpp

---------

Co-authored-by: briaguya <70942617+briaguya-ai@users.noreply.github.com>

* Fixes kaleido dungeon maps (#67)

* skeleton stuff (#69)

* comment out wii u build (#70)

* bump lus (#71)

* Rework readme (#72)

* Update README.md

* docs

* put custom music docs somewhere

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* dark/light title image

* lus

* Update README.md

* Fixed vanilla minimap (#73)

* Fixed vanilla minimap

* Workaround for pulsing SD maps with non-broken HD maps.

---------

Co-authored-by: Christopher Leggett <chris@leggett.dev>

* Skeleton fix fixed (#75)

* WIP skelton patcher fix

* Fixes skeleton reference change.

* Adds const back to name in ResourceMgr_LoadSkeletonByName

---------

Co-authored-by: Christopher Leggett <chris@leggett.dev>
Co-authored-by: Kenix <kenixwhisperwind@gmail.com>

* Fixes z_message_otr memory leak.

* Update soh/soh/z_message_OTR.cpp

* Update soh/src/code/game.c

* docs: add how to find otr files to switch instructions (#78)

* bump lus (#79)

* comment out RegisterBlendedTexture in king d (#80)

---------

Co-authored-by: Nicholas Estelami <NEstelami@users.noreply.github.com>
Co-authored-by: David Chavez <david@dcvz.io>
Co-authored-by: briaguya <briaguya@alice>
Co-authored-by: Kenix3 <kenixwhisperwind@gmail.com>
Co-authored-by: KiritoDv <kiritodev01@gmail.com>
Co-authored-by: briaguya <briaguya>
Co-authored-by: Ralphie Morell <stratomaster64@gmail.com>
Co-authored-by: MelonSpeedruns <melonspeedruns@outlook.com>
Co-authored-by: Adam Bird <Archez@users.noreply.github.com>
Co-authored-by: inspectredc <78732756+inspectredc@users.noreply.github.com>
Co-authored-by: Patrick12115 <115201185+Patrick12115@users.noreply.github.com>
Co-authored-by: Rozelette <Rozelette@users.noreply.github.com>
Co-authored-by: Christopher Leggett <chris@leggett.dev>
Co-authored-by: Lywx <36680385+KiritoDv@users.noreply.github.com>
Malkierian pushed a commit to Malkierian/Shipwright that referenced this issue Nov 20, 2023
@dcvz @briaguya-ai @Kenix3
[Fast3D] Metal Renderer (HarbourMasters#80)
231e417 
* Add Metal renderer

* Run clang-format

* Fix build

* Use Metal single header

* Fix compilation

* Update metal-cpp

* Simplify vertex buffer re-usage

* Enable viewports on Metal

* Fix up some cmake stuff

* Fix rebase with latest

* Update src/graphic/Fast3D/gfx_metal.cpp

Co-authored-by: briaguya <70942617+briaguya-ai@users.noreply.github.com>

* Small fixes after latest main merge

* Names GameOverlay class method arguments consistently.

* Uses correct naming convention for imgui code.

* Fixes some missed variable names.

* Format files.

* Adds a missing brace to an if statement.

* Fixes Metal.Renderer references.

---------

Co-authored-by: briaguya <70942617+briaguya-ai@users.noreply.github.com>
Co-authored-by: Kenix <kenixwhisperwind@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leggettc18 leggettc18

Labels
bug Something isn't working
Projects
None yet
Milestone
Zhora Bravo/Charlie/Delta etc.
Development

No branches or pull requests
8 participants
@aMannus @xoniq @MegaMech @garrettjoecox @Kenix3 @leggettc18 @briaguya-ai @NitrousTheIceFox