Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spacebar Menu Scale and Rotate Buttons Do Nothing When Interacted With #6496

Closed
Exairnous opened this issue Sep 3, 2024 · 3 comments
Closed

Spacebar Menu Scale and Rotate Buttons Do Nothing When Interacted With #6496

Exairnous opened this issue Sep 3, 2024 · 3 comments
Labels
bug needs triage For bugs that have not yet been assigned a fix priority

Comments

@Exairnous
Copy link
Contributor

Exairnous commented Sep 3, 2024 •
edited
Loading

Description
Objects can't be manipulated via the scale and rotate buttons from the spacebar menu anymore.

To Reproduce
Steps to reproduce the behavior:

  1. Enter a Hubs room.
  2. Spawn a duck with the /duck chat command.
  3. Hover over the duck and press and hold the spacebar to bring up the menu.
  4. Click and drag on the scale or rotate buttons while holding the spacebar.
  5. See that the duck moves instead of scaling or rotating.

Expected behavior
The object should be scaled or rotated, depending on which button is interacted with.

Video
https://github.com/user-attachments/assets/ed28a602-5af2-4ff6-aba6-6bf401f1972e
Video courtesy of mr. lion on Discord.

Hardware

  • Device: Laptop
  • OS: GNU/Linux
  • Browser: Chromium

Additional context
Potentially caused by #6495
Potentially caused by #6487
Physics also seems to be affected by this bug. Objects can no longer be thrown and the gravity/drop to floor button on the spacebar button does nothing if the object has been moved. Update: the physics issues are probably a separate bug and have been reported in #6503, #6504, #6505
@Exairnous Exairnous added bug needs triage For bugs that have not yet been assigned a fix priority labels Sep 3, 2024
@DougReeder
Copy link
Contributor

I used those so seldom that I've forgotten how they are supposed to work. Do we have any videos of the rotate and scale buttons working properly?

Exairnous added a commit that referenced this issue Sep 24, 2024
@Exairnous
Revert 699187a and part of 1567f22
0f09fae 
Fixes #6496

Chromium version 128 introduced a bug in Hubs that was fixed by
#6495 but PR#6495 seems
to have introduced the bug detailed in issue#6496 for all browsers.
Now Chromium has fixed an issue on their end as detailed here:
https://issues.chromium.org/issues/361823993 which should fix
the original bug that PR#6495 addressed in Hubs, which allows us
to revert the fix on the Hubs side (PR#6495) and so fix the
issue#6496 bug.  However, this doesn't do anything for the
potentially deeper issues in the system that were possibly exposed
with PR#6495.
@Exairnous Exairnous mentioned this issue Sep 24, 2024
Closed
DougReeder added a commit to DougReeder/hubs that referenced this issue Sep 26, 2024
@DougReeder
Fixes Hubs-Foundation#6496 - scale & rotate buttons
b26ca00
@Exairnous
Copy link
Contributor Author

@DougReeder
While not the greatest quality, videos of the buttons working can be found in the description of this issue: #6405

@Exairnous Exairnous mentioned this issue Nov 7, 2024
Merged
Exairnous added a commit that referenced this issue Nov 7, 2024
@Exairnous
Revert Scene grabbables support PR and fix the bugs caused by it
0dabc28 
Reverts "Merge pull request #6487 from mozilla/scene-grabbables".

This reverts commit 4324d10, reversing
changes made to 746413d.

This fixes the following GitHub bugs:
Spacebar Menu Scale and Rotate Buttons Do Nothing When Interacted With #6496
Physics doesn't work when in-room objects are thrown #6503
Physics doesn't continue working after moving an object that has had physics permanently enabled on it #6504
The spacebar menu doesn't show up for objects which have been dropped in the room from a file browser #6505

This reverts the changes from the following commits:
c23b7d4
Add warning for negative scale when creating interactables bounds

ae050ee
Revert media collision mask

ec12e4c
Scene grabbables support
@Exairnous
Copy link
Contributor Author

Fixed by #6515

@Exairnous Exairnous mentioned this issue Nov 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug needs triage For bugs that have not yet been assigned a fix priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix bug: Spacebar Menu Scale and Rotate Buttons Do Nothing When Interacted With Hubs-Foundation/hubs
2 participants
@DougReeder @Exairnous