Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scene grabbables support #6487

Merged
merged 3 commits into from
May 8, 2024
Merged

Scene grabbables support #6487

merged 3 commits into from
May 8, 2024

Conversation

keianhzo
Copy link
Contributor

@keianhzo keianhzo commented May 2, 2024

This PR adds support for grabbale objects in Hubs. Now using the grabbale component (Hubs-Foundation/hubs-blender-exporter#282) Any scene object can be grabbable and capturable by a media frame.

Related Hubs-Foundation/blender-gltf-behavior-graph#16

@Exairnous
Copy link
Contributor

I ran into this error when testing a scene with two grabbable cubes (one with the media frames collision mask, one without), a plane with a physics shape set to convex hull for the floor, and a media frame set to all objects; this was exported using the new PRs to the add-ons for this feature:

mediaLoaderObj is undefined
./src/bit-systems/media-loading.ts/mediaLoadingSystem/<@https://hubs.local:8080/assets/js/hub-86783bd68c802e0becf6.js:7122:5
mediaLoadingSystem@https://hubs.local:8080/assets/js/hub-86783bd68c802e0becf6.js:7113:32
mainTick@https://hubs.local:8080/assets/js/hub-86783bd68c802e0becf6.js:65147:82
./src/app.ts/setupRenderer/</</<@https://hubs.local:8080/assets/js/hub-86783bd68c802e0becf6.js:3732:74
onAnimationFrame@https://hubs.local:8080/assets/js/engine-f7f00df9e9582890925b.js:33685:59
onAnimationFrame@https://hubs.local:8080/assets/js/engine-f7f00df9e9582890925b.js:19340:16

@keianhzo
Copy link
Contributor Author

keianhzo commented May 7, 2024

I couldn't reproduce this on my end, maybe we can take a look at it at the Meetup.

I ran into this error when testing a scene with two grabbable cubes (one with the media frames collision mask, one without), a plane with a physics shape set to convex hull for the floor, and a media frame set to all objects; this was exported using the new PRs to the add-ons for this feature:

@Exairnous
Copy link
Contributor

Sure, we can check it at the meetup.

@Exairnous
Copy link
Contributor

Strange. I can't reproduce it now either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants