Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed ui in protected terms files as the 'enabled' checkbox was too small #10438

Merged
merged 6 commits into from
Oct 8, 2023
Merged

Fixed ui in protected terms files as the 'enabled' checkbox was too small #10438

merged 6 commits into from
Oct 8, 2023

Conversation

Harish-2403
Copy link
Contributor

@Harish-2403 Harish-2403 commented Oct 2, 2023 •
edited by Siedlerchr
Loading

Fixed the User Interface improvement in protected terms files as the "enabled" was not visible in the title of the checkbox
Fixes #10285

grafik

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@Siedlerchr
Copy link
Member

Please also make sure to check that resize issue

@Siedlerchr
remove max width
ba9be75
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into fix/ui-improvement-…
46bad1d 
…in-protected-terms-files

* upstream/main:
  Update src/main/java/org/jabref/logic/exporter/AtomicFileOutputStream.java
  Fix saving on network drive under macOS
  Infer DOI from ArXiv identifier (JabRef#10449)
  Add TexShop Icon (JabRef#10447)
  Fix PDF export (JabRef#10361)
  Fixed SpringerFetcherTest and ACMPortalFetcherTest (JabRef#10445)
  Bump org.openrewrite.rewrite from 6.3.11 to 6.3.16 (JabRef#10442)
  Update all of lucene
  Bump org.apache.lucene:lucene-core from 9.7.0 to 9.8.0
  Bump com.dlsc.gemsfx:gemsfx from 1.77.0 to 1.82.0
  Accept LaTeX errors in comment field (JabRef#10436)
  fix checkstyle
  fix escaping of slashes
  fix checkstyle  and l10n
  Add TeXShop (macOS only)
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into fix/ui-improvement-…
630d7c1 
…in-protected-terms-files

* upstream/main:
  Simplify code (JabRef#10460)
  Mark download PDF test as fetcher test (JabRef#10457)
@Siedlerchr
add changelog
b288ab2
Siedlerchr
Siedlerchr previously approved these changes Oct 8, 2023
View reviewed changes
@Siedlerchr Siedlerchr enabled auto-merge October 8, 2023 17:15
@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Oct 8, 2023
@Siedlerchr Siedlerchr added this pull request to the merge queue Oct 8, 2023
Merged via the queue into JabRef:main with commit 220ae72 Oct 8, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

user interface: small improvement request
2 participants
@Harish-2403 @Siedlerchr