New global search #8045
Merged
New global search #8045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: Remove on closing tab
TODO: set SearchQuery also to other tabs then
extract table
Clear and readd new entries TODO: Create some kind of bindings?
* upstream/main: Switch to archive.org for site.icu-project.org Add Java Profiler Fix output when closing JabRef while indexing (#8043) Remove explicit XMP import for PDFs (#8040) Fix crosses Stop indexing on cancel (#8039) Write embedded bib in addition to XMP metadata (#8037) Cleanup preferences (#8036) Fix Search dark mode theme (#8028) Allow the search to return multiple entries. (#8038) Refactored GroupTree.fxml to plain java (#8035)
Extract libary tab logic to file utils
add global Search property
Siedlerchr
added
the
status: ready-for-review
…obalSearch * 'newGlobalSearch' of github.com:JabRef/jabref: Update DialogService.java
|
@ytzemih Great news: @Siedlerchr was able to bring back the GlobalSearchDialog. |
tobiasdiez
requested changes
Sep 1, 2021
src/main/java/org/jabref/gui/search/GlobalSearchResultDialog.java
Outdated
Show resolved
Hide resolved
src/main/java/org/jabref/gui/search/GlobalSearchResultDialog.java
Outdated
Show resolved
Hide resolved
src/main/java/org/jabref/gui/search/GlobalSearchResultDialog.java
Outdated
Show resolved
Hide resolved
| import org.jabref.model.database.BibDatabaseContext; | ||
| import org.jabref.preferences.PreferencesService; | ||
|
|
||
| public class SearchResultsTable extends TableView<BibEntryTableViewModel> { |
There was a problem hiding this comment.
As this class has quite a bit of code duplication with the main table, can we have one class that handles the display of entries (in a table). Would make it easier to reuse it.
There was a problem hiding this comment.
I know, but it's just part of the constructor and this is exactly what the want. Show the user a table he's familiar with
There was a problem hiding this comment.
I think this would escalate this PR way too much. Probably something for a later code quality PR.
* upstream/main: Enable copy&paste for IntelliJ run configuration GitBook: [main] one page modified GitBook: [main] one page modified GitBook: [main] 19 pages and 6 assets modified Refine documentation Oobranch f : add frontend (#7791) Observable Preferences C (General) (#8047) Welcome btut 🎉 Observable preferences B (ProtectedTerms, EntryEditor and MrDlib) (#8046) Refine howto (#8049) Decision on handling of localized preferences. Added option to import CFF files (#7946) Observable preferences A (Appearance and Importer) (#8041) Squashed 'buildres/csl/csl-locales/' changes from ec6d62a9e7..7a507fc008 Squashed 'buildres/csl/csl-styles/' changes from ec4a4c0..2b37392
calixtus
approved these changes
Sep 2, 2021
koppor
approved these changes
Sep 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4096
Experimental implementation of the global search.
__
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)