Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dev-deps): update ledger-cosmos-go from v0.12.2 to v0.12.4 and ledger-go from v0.14.1 to v0.14.3 #145

Closed
wants to merge 39 commits into from

Conversation

johnletey and others added 30 commits April 19, 2023 14:02
Co-authored-by: John Letey <john@kyve.network>
Co-authored-by: John Letey <john@kyve.network>
Co-authored-by: John Letey <john@kyve.network>
Co-authored-by: Max Breithecker <max@kyve.network>
Co-authored-by: John Letey <john@kyve.network>
Co-authored-by: Troy Kessler <43882936+troykessler@users.noreply.github.com>
Co-authored-by: mbreithecker <m@breithecker.de>
Co-authored-by: John Letey <john@kyve.network>
Co-authored-by: Troy Kessler <troy.kessler99@gmail.com>
@mbreithecker
Copy link
Member

mbreithecker commented Nov 10, 2023

Hey @zakarialounes ,
thanks for the PR. However, I think your fork is out of sync, the ledger dependencies were already updated in this PR: #139

@zakarialounes
Copy link
Author

Indeed, I started from tag v1.3.1. So I'm closing this PR since it's of no use. Thank you.

@zakarialounes
Copy link
Author

What's strange @mbreithecker is that GitHub detects a change, since it allowed me to create the PR. I'll leave it to you to check whether the change is actually there.

@zakarialounes zakarialounes reopened this Nov 10, 2023
@zakarialounes
Copy link
Author

I thought that GitHub would detect that the changes were already there, but obviously it's having trouble. Since the changes are there, I'm closing the PR.

@zakarialounes zakarialounes deleted the fix-deps-ledger branch November 10, 2023 14:33
@mbreithecker
Copy link
Member

You are right, this is indeed very strange. I also did a diff on my local machine and apparently Github is having some troubles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants