Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "cleanup: remove pulumi deplendency, use third_party instead (#68)" #190

Merged
merged 1 commit into from
Dec 8, 2022

Conversation

howieyuen
Copy link
Collaborator

This reverts commit f36425ff9e354c6cf49d4688bab7120a11725ba4.

The initial aim is to reduce kusion binary size, so remove the pulumi sdk, use third-party instead. However, I found the size is not really reduced a lot, event not 1 MB:

image

Use 3rd-party, size is 49918992
Use module dependency, size is 50364496
Only reduced 50364496 - 49918992 = 445504, roughly equal to 450 KB

@howieyuen howieyuen added the kind/optimization Code optimization label Dec 7, 2022
@howieyuen howieyuen enabled auto-merge (squash) December 7, 2022 09:30
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3637580773

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 10 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.1%) to 72.144%

Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/parser/parser.go 3 75.0%
pkg/kusionctl/cmd/apply/options.go 7 70.16%
Totals Coverage Status
Change from base Build 3620276350: -0.1%
Covered Lines: 4566
Relevant Lines: 6329

💛 - Coveralls

@howieyuen howieyuen merged commit ebdacc8 into KusionStack:main Dec 8, 2022
@howieyuen howieyuen deleted the revert-pulumi branch December 8, 2022 03:53
@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/optimization Code optimization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants