Add setLocale method
#478
Merged
Add setLocale method
#478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
batadamnjanovic
force-pushed
the
feature/enable_custom_locale
branch
from
e8c2393
to
5d53194
Compare
|
Hi @batadamnjanovic, what is your idea in adding setter method, because you can easily change the device's language if you want to test locales? |
|
Hi @hborisoff, this is similar to Web: Leanplum/Leanplum-JavaScript-SDK#140 and iOS: Leanplum/Leanplum-iOS-SDK#467. We have predefined language codes that we need to send with every event. |
hborisoff
approved these changes
Dec 15, 2021
|
Hi @hborisoff, thanks for the collaboration. Do you maybe know when will be the next release if it's not a secret? It will mean a lot to us to organise some things in this sprint. Thanks! |
hborisoff
pushed a commit
that referenced
this pull request
Dec 16, 2021
* Enable custom locale * Update setLocale method comment
|
@batadamnjanovic Yesterday I was working on a release 5.8.2 containing a bug fix and included your change too. |
hborisoff
pushed a commit
that referenced
this pull request
Jan 24, 2022
* Enable custom locale * Update setLocale method comment
hborisoff
added a commit
that referenced
this pull request
Jan 24, 2022
* Release 5.9.0-beta1 * Use new URL for artifactory instance * Release 5.9.0-beta2 * Release 5.9.0-beta3 * Try fix path for artifactory * Release 5.9.0-beta4 * try fix build * Release 5.9.0-beta5 * Release and fix build 5.9.0-beta6 * Add Leanplum.setLocale (#478) * Enable custom locale * Update setLocale method comment * Validate advertising id for zero value (#479) * Release 5.9.0-beta7 * Add exception listener to Log class (#481) * Release 5.9.0-beta8 * Release 5.9.0 Co-authored-by: Bratislav Damnjanovic <damnjanovic.bata@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce
setLocale(locale: String)in order to set a custom locale string.Problem with this approach is that
setLocale(...)needs to be called beforeLeanplum.start(...)method.