Feature/set locale #467
Feature/set locale #467
Conversation
| /** | ||
| * Tests setting the user locale after Leanplum start | ||
| */ | ||
| - (void) test_set_locale |
There was a problem hiding this comment.
You can simplify the test to:
- (void) test_set_locale
{
NSLocale *locale = [[NSLocale alloc] initWithLocaleIdentifier:@"ab_CD"];
XCTestExpectation *request_expectation =
[self expectationWithDescription:@"request_expectation"];
[LPRequestSender validate_request_args_dictionary:^(NSDictionary *args) {
XCTAssertTrue([args[LP_KEY_LOCALE] isEqualToString:[locale localeIdentifier]]);
XCTAssertFalse([args[LP_KEY_LOCALE] isEqualToString:[[NSLocale currentLocale] localeIdentifier]]);
[request_expectation fulfill];
}];
[Leanplum setLocale:locale];
[self waitForExpectations:@[request_expectation] timeout:1.0];
}There was a problem hiding this comment.
Tests has been updated
| @@ -2249,6 +2249,14 @@ + (void)setTrafficSourceInfoInternal:(NSDictionary *)info | |||
| [[LPRequestSender sharedInstance] send:request]; | |||
| } | |||
|
|
|||
| + (void)setLocale:(NSLocale *)locale | |||
| { | |||
There was a problem hiding this comment.
What is the use case - would this be called before starting Leanplum or at some point after it started?
If it has started, the locale in the start API call will be the system one.
There was a problem hiding this comment.
The idea was for calling it after Leanplum is started, in order to simplify a bit complex variations of starting.
If you think it is better to move it to start, and/or to add some stored property for overriding the system's locale, so the start would take that one, I'm ok with it as well.
There was a problem hiding this comment.
Improved in a way that setLocale now can be called both before and after Leanplum is started
|
Hi @nzagorchev, thanks for the collaboration. Do you maybe know when will be the release with this change? It will mean a lot to us to organise some things in this sprint. Thanks! |
|
Hi @batadamnjanovic, Can you update the PR, so I can merge it into master after that? |
|
Hi @nzagorchev the PR has been updated (proposed changes) also the branch has been updated with |
Proposed Changes
Currently the
localeparameter is sent along when callingstart(), but there is no way to override it.This PR introduces
setLocaleAPI which can be called before or afterstart().The Leanplum class now have private property for overriding the system locale.
Similar approach has been done in Leanplum/Leanplum-JavaScript-SDK#140