Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add setLocale method #140

Merged
merged 4 commits into from
Nov 3, 2021
Merged

Add setLocale method #140

merged 4 commits into from
Nov 3, 2021

Conversation

wil93
Copy link
Contributor

@wil93 wil93 commented Nov 1, 2021

Proposed Changes

Currently the locale parameter is sent along when calling start(), but there is no way to avoid it being set to "(detect)"

This PR introduces setLocale which can be called before start(), similarly to what can already be done with setDeviceName

@gyoshev
Copy link
Contributor

gyoshev commented Nov 3, 2021 •
edited
Loading

Hello @wil93, and thank you for your contribution!

I fixed a small lint error and added a few tests for completeness sake.

The method will be released in version 1.9.0, most probably next week.

@gyoshev gyoshev merged commit 5b7467c into Leanplum:develop Nov 3, 2021
@wil93 wil93 deleted the set-locale branch November 4, 2021 08:32
@fitja fitja mentioned this pull request Dec 2, 2021
Merged
@batadamnjanovic batadamnjanovic mentioned this pull request Dec 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gyoshev gyoshev gyoshev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wil93 @gyoshev