Update logic for checking TPUs availability #6767

kaushikb11 · 2021-03-31T16:11:26Z

What does this PR do?

Update logic for checking TPUs availability. Related to #6692

Before submitting

Was this discussed/approved via a GitHub issue? (not for typos and docs)
Did you read the contributor guideline, Pull Request section?
Did you make sure your PR does only one thing, instead of bundling different changes together?
Did you make sure to update the documentation with your changes? (if necessary)
Did you write any new necessary tests? (not for typos and docs)
Did you verify new and existing tests pass locally with your changes?
Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

Is this pull request ready for review? (if not, please submit in draft mode)
Check that all items from Before submitting are resolved
Make sure the title is self-explanatory and the description concisely explains the PR
Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

tchaton

LGTM !

tchaton · 2021-03-31T16:14:50Z

pytorch_lightning/utilities/xla_device.py

-        queue = smp.SimpleQueue()
-        xmp.spawn(_fn, args=(queue, ), nprocs=1)
-        return queue.get()
+        return len(xm.get_xla_supported_devices("TPU")) > 0


Really nice !

tchaton · 2021-03-31T16:14:57Z

pytorch_lightning/plugins/training_type/tpu_spawn.py

@@ -118,6 +118,9 @@ def new_process(self, process_idx: int, trainer, mp_queue) -> None:
        self.__save_end_of_training_weights(self.lightning_module)
        self.transfer_distrib_spawn_state_on_fit_end(results)

+        if self.global_rank == 0:


codecov · 2021-03-31T18:57:46Z

Codecov Report

Merging #6767 (7c1dbee) into master (495c385) will decrease coverage by 5%.
The diff coverage is 50%.

@@           Coverage Diff           @@
##           master   #6767    +/-   ##
=======================================
- Coverage      91%     87%    -5%     
=======================================
  Files         192     192            
  Lines       12182   12191     +9     
=======================================
- Hits        11146   10597   -549     
- Misses       1036    1594   +558

Borda · 2021-03-31T21:21:14Z

pytorch_lightning/plugins/training_type/tpu_spawn.py

@@ -118,6 +118,9 @@ def new_process(self, process_idx: int, trainer, mp_queue) -> None:
        self.__save_end_of_training_weights(self.lightning_module)
        self.transfer_distrib_spawn_state_on_fit_end(results)

+        if self.global_rank == 0:
+            time.sleep(2)


any reason why 2?

* Update logic for checking TPUs availability * fix flake8 * add fix

* update readme by v1.2.x (#6728) * [bugfix] Add support for omegaconf and tpu (#6741) * fix_hydra * update changelog Co-authored-by: Your Name <you@example.com> * [docs] Update Bolts link (#6743) * Update Bolts link * Update Bolts link * formt Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> * Update logic for checking TPUs availability (#6767) * Update logic for checking TPUs availability * fix flake8 * add fix * resolve bug (#6781) * Fix validation progress counter with check_val_every_n_epoch > 1 (#5952) Co-authored-by: rohitgr7 <rohitgr1998@gmail.com> Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com> * Remove extinct parameters from lightning_module.rst (#6801) Fixes #6800 * Update TPU docs for installation (#6794) * fix boolean check on iterable dataset when len not defined (#6828) * fix iterable dataset len check * update predict and validate * add validate to test * add changelog * add predict * Sanitize `None` params during pruning (#6836) * sanitize none params during pruning * amend * Fix `unfreeze_and_add_param_group` expects `modules` rather than `module` (#6822) * Enforce an epoch scheduler interval when using SWA (#6588) Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com> * Fix DPP + SyncBN (#6838) * Fix DPP + SyncBN Ensure that model is already on correct GPU before applying SyncBN conversion * Fix order of SyncBN for ddp_spawn * [Fix] TPU Training Type Plugin (#6816) * Fix support for symlink save_dir in TensorBoardLogger (#6730) * Add test for symlink support and initial fix * Respond to comment and add docstring * Update CHANGELOG.md * Simplify * Update pytorch_lightning/utilities/cloud_io.py Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com> * Make `LightningLocalFileSystem` protected Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com> * Fixed missing arguments in `lr_find` call (#6784) There seem to be 3 arguments missing in the `lr_find` call in the tunining.py file. * Update Changelog & version * Fix TPU tests for checkpoint Skip advanced profiler for torch > 1.8 Skip pytorch profiler for torch > 1.8 Fix save checkpoint logic for TPUs Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> Co-authored-by: thomas chaton <thomas@grid.ai> Co-authored-by: Your Name <you@example.com> Co-authored-by: Akihiro Nitta <nitta@akihironitta.com> Co-authored-by: Yuan-Hang Zhang <sailordiary@users.noreply.github.com> Co-authored-by: rohitgr7 <rohitgr1998@gmail.com> Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com> Co-authored-by: Elizaveta Logacheva <elimohl@gmail.com> Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com> Co-authored-by: Karthik Prasad <prasadkr@uci.edu> Co-authored-by: Sadiq Jaffer <sadiq@toao.com> Co-authored-by: Michael Baumgartner <m.baumgartner@ymail.com> Co-authored-by: Eugene Khvedchenya <ekhvedchenya@gmail.com> Co-authored-by: Ethan Harris <ewah1g13@soton.ac.uk> Co-authored-by: Tharindu Hasthika <tharindubathigama@gmail.com>

* Update logic for checking TPUs availability * fix flake8 * add fix

Update logic for checking TPUs availability

97d5b52

kaushikb11 requested review from awaelchli, Borda, carmocca, justusschock, SeanNaren and tchaton as code owners March 31, 2021 16:11

kaushikb11 self-assigned this Mar 31, 2021

kaushikb11 added the bug Something isn't working label Mar 31, 2021

kaushikb11 added this to the 1.2.x milestone Mar 31, 2021

tchaton approved these changes Mar 31, 2021

View reviewed changes

kaushikb11 added 2 commits March 31, 2021 21:54

fix flake8

bdc2710

add fix

7c1dbee

awaelchli approved these changes Mar 31, 2021

View reviewed changes

kaushikb11 mentioned this pull request Mar 31, 2021

[TPU] Correct the check for TPU device in a pod environment #6755

Closed

11 tasks

tchaton approved these changes Mar 31, 2021

View reviewed changes

Borda approved these changes Mar 31, 2021

View reviewed changes

kaushikb11 merged commit 13f67ad into Lightning-AI:master Mar 31, 2021

This was referenced Apr 1, 2021

No TPU devices were found in a TPU pod env. #6692

Closed

No TPU devices were found. #6778

Closed

1.2.x cherries 🍒 #6083

Closed

kaushikb11 added a commit to kaushikb11/pytorch-lightning that referenced this pull request Apr 6, 2021

Update logic for checking TPUs availability (Lightning-AI#6767)

709b695

* Update logic for checking TPUs availability * fix flake8 * add fix

lexierule pushed a commit that referenced this pull request Apr 7, 2021

Update logic for checking TPUs availability (#6767)

ce5420a

* Update logic for checking TPUs availability * fix flake8 * add fix

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update logic for checking TPUs availability #6767

Update logic for checking TPUs availability #6767

kaushikb11 commented Mar 31, 2021 •

edited

Loading

tchaton left a comment

tchaton Mar 31, 2021

tchaton Mar 31, 2021

codecov bot commented Mar 31, 2021 •

edited

Loading

Borda Mar 31, 2021

kaushikb11 Mar 31, 2021

Update logic for checking TPUs availability #6767

Update logic for checking TPUs availability #6767

Conversation

kaushikb11 commented Mar 31, 2021 • edited Loading

What does this PR do?

Before submitting

PR review

Did you have fun?

tchaton left a comment

Choose a reason for hiding this comment

tchaton Mar 31, 2021

Choose a reason for hiding this comment

tchaton Mar 31, 2021

Choose a reason for hiding this comment

codecov bot commented Mar 31, 2021 • edited Loading

Codecov Report

Borda Mar 31, 2021

Choose a reason for hiding this comment

kaushikb11 Mar 31, 2021

Choose a reason for hiding this comment

kaushikb11 commented Mar 31, 2021 •

edited

Loading

codecov bot commented Mar 31, 2021 •

edited

Loading