Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update TPU docs for installation #6794

Merged
merged 1 commit into from
Apr 3, 2021
Merged

Update TPU docs for installation #6794

merged 1 commit into from
Apr 3, 2021

Conversation

kaushikb11
Copy link
Contributor

What does this PR do?

Ref: pytorch/xla#2813

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the docs Documentation related label Apr 1, 2021
Borda
Borda reviewed Apr 1, 2021
View reviewed changes
docs/source/advanced/tpu.rst
@@ -64,8 +64,7 @@ To get a TPU on colab, follow these steps:

.. code-block::

!curl https://raw.githubusercontent.com/pytorch/xla/master/contrib/scripts/env-setup.py -o pytorch-xla-env-setup.py
!python pytorch-xla-env-setup.py --version 1.7 --apt-packages libomp5 libopenblas-dev
!pip install cloud-tpu-client==0.10 https://storage.googleapis.com/tpu-pytorch/wheels/torch_xla-1.8-cp37-cp37m-linux_x86_64.whl
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well here the XLA version shall be aligned with PT version, right?

Copy link
Contributor Author

@kaushikb11 kaushikb11 Apr 1, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The instructions are for Colab & they have updated the runtime to use torch>=1.8.0

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this same command work for kaggle?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lezwon Just checked. It's 1.7 for Kaggle notebooks.
We could add {torch.__version__} to the URL as a placeholder.

@codecov
Copy link

codecov bot commented Apr 1, 2021 •
edited
Loading

Codecov Report

Merging #6794 (a1de5cf) into master (13f67ad) will decrease coverage by 5%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #6794    +/-   ##
=======================================
- Coverage      92%     87%    -5%     
=======================================
  Files         192     192            
  Lines       12174   12248    +74     
=======================================
- Hits        11147   10618   -529     
- Misses       1027    1630   +603

@awaelchli awaelchli added the accelerator: tpu Tensor Processing Unit label Apr 2, 2021
@kaushikb11 kaushikb11 added the ready PRs ready to be merged label Apr 2, 2021
@mergify mergify bot requested a review from a team April 2, 2021 20:01
@kaushikb11 kaushikb11 merged commit 22a266d into Lightning-AI:master Apr 3, 2021
@kaushikb11 kaushikb11 deleted the tpu/docs branch April 3, 2021 18:49
@minimaxir minimaxir mentioned this pull request Apr 3, 2021
Merged
@kaushikb11 kaushikb11 added this to the 1.2.x milestone Apr 5, 2021
@kaushikb11 kaushikb11 mentioned this pull request Apr 5, 2021
Closed
kaushikb11 added a commit to kaushikb11/pytorch-lightning that referenced this pull request Apr 6, 2021
@kaushikb11
Update TPU docs for installation (Lightning-AI#6794)
2ceed8a
lexierule pushed a commit that referenced this pull request Apr 7, 2021
@kaushikb11 @Borda
@tchaton @akihironitta @sailordiary @rohitgr7 @carmocca @elimohl @awaelchli @karthikprasad @sadiqj @mibaumgartner @BloodAxe @ethanwharris @THasthika
Weekly Patch Release v.1.2.7 [full merge, no squash] (#6850)
b2c7345 
* update readme by v1.2.x (#6728)

* [bugfix] Add support for omegaconf and tpu (#6741)

* fix_hydra

* update changelog

Co-authored-by: Your Name <you@example.com>

* [docs] Update Bolts link (#6743)

* Update Bolts link

* Update Bolts link

* formt

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>

* Update logic for checking TPUs availability (#6767)

* Update logic for checking TPUs availability

* fix flake8

* add fix

* resolve bug (#6781)

* Fix validation progress counter with check_val_every_n_epoch > 1 (#5952)

Co-authored-by: rohitgr7 <rohitgr1998@gmail.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

* Remove extinct parameters from lightning_module.rst (#6801)

Fixes  #6800

* Update TPU docs for installation (#6794)

* fix boolean check on iterable dataset when len not defined (#6828)

* fix iterable dataset len check

* update predict and validate

* add validate to test

* add changelog

* add predict

* Sanitize `None` params during pruning (#6836)

* sanitize none params during pruning

* amend

* Fix `unfreeze_and_add_param_group` expects `modules` rather than `module` (#6822)

* Enforce an epoch scheduler interval when using SWA (#6588)

Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>

* Fix DPP + SyncBN (#6838)

* Fix DPP + SyncBN

Ensure that model is already on correct GPU before applying SyncBN conversion

* Fix order of SyncBN for ddp_spawn

* [Fix] TPU Training Type Plugin (#6816)

* Fix support for symlink save_dir in TensorBoardLogger (#6730)

* Add test for symlink support and initial fix

* Respond to comment and add docstring

* Update CHANGELOG.md

* Simplify

* Update pytorch_lightning/utilities/cloud_io.py

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

* Make `LightningLocalFileSystem` protected

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

* Fixed missing arguments in `lr_find` call (#6784)

There seem to be 3 arguments missing in the `lr_find` call in the tunining.py file.

* Update Changelog & version

* Fix TPU tests for checkpoint

Skip advanced profiler for torch > 1.8

Skip pytorch profiler for torch > 1.8

Fix save checkpoint logic for TPUs

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: thomas chaton <thomas@grid.ai>
Co-authored-by: Your Name <you@example.com>
Co-authored-by: Akihiro Nitta <nitta@akihironitta.com>
Co-authored-by: Yuan-Hang Zhang <sailordiary@users.noreply.github.com>
Co-authored-by: rohitgr7 <rohitgr1998@gmail.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Elizaveta Logacheva <elimohl@gmail.com>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Co-authored-by: Karthik Prasad <prasadkr@uci.edu>
Co-authored-by: Sadiq Jaffer <sadiq@toao.com>
Co-authored-by: Michael Baumgartner <m.baumgartner@ymail.com>
Co-authored-by: Eugene Khvedchenya <ekhvedchenya@gmail.com>
Co-authored-by: Ethan Harris <ewah1g13@soton.ac.uk>
Co-authored-by: Tharindu Hasthika <tharindubathigama@gmail.com>
lexierule pushed a commit that referenced this pull request Apr 7, 2021
@kaushikb11 @lexierule
Update TPU docs for installation (#6794)
f8ed4d4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lezwon lezwon lezwon left review comments

@akihironitta akihironitta akihironitta approved these changes

@Borda Borda Borda approved these changes

@awaelchli awaelchli awaelchli approved these changes

@edenlightning edenlightning Awaiting requested review from edenlightning

@tchaton tchaton Awaiting requested review from tchaton

Assignees
No one assigned
Labels
accelerator: tpu Tensor Processing Unit docs Documentation related ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.2.x
Development

Successfully merging this pull request may close these issues.
5 participants
@kaushikb11 @awaelchli @Borda @lezwon @akihironitta