Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed missing arguments in lr_find call #6784

Merged
merged 1 commit into from
Apr 6, 2021
Merged

Fixed missing arguments in lr_find call #6784

merged 1 commit into from
Apr 6, 2021

Conversation

THasthika
Copy link
Contributor

@THasthika THasthika commented Apr 1, 2021 •
edited by Borda
Loading

There seem to be 3 arguments missing in the lr_find call in the tunining.py file.

What does this PR do?

Adds the 3 arguments stated in the issue to the lr_find call.

Fixes #6783

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@THasthika
Fixed missing arguments in lr_find call
a0864ab 
There seem to be 3 arguments missing in the `lr_find` call in the tunining.py file.
@codecov
Copy link

codecov bot commented Apr 1, 2021 •
edited
Loading

Codecov Report

Merging #6784 (a0864ab) into master (3e3175d) will decrease coverage by 5%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #6784    +/-   ##
=======================================
- Coverage      92%     87%    -5%     
=======================================
  Files         192     192            
  Lines       12170   12170            
=======================================
- Hits        11144   10594   -550     
- Misses       1026    1576   +550

@awaelchli awaelchli added tuner bug Something isn't working labels Apr 2, 2021
@ananthsub
Copy link
Contributor

are there tests for this?

@Borda Borda merged commit f581411 into Lightning-AI:master Apr 6, 2021
@kaushikb11 kaushikb11 mentioned this pull request Apr 6, 2021
Closed
kaushikb11 pushed a commit to kaushikb11/pytorch-lightning that referenced this pull request Apr 6, 2021
@THasthika @kaushikb11
Fixed missing arguments in lr_find call (Lightning-AI#6784)
653232c 
There seem to be 3 arguments missing in the `lr_find` call in the tunining.py file.
This was referenced Apr 6, 2021
Closed
Closed
lexierule pushed a commit that referenced this pull request Apr 7, 2021
@kaushikb11 @Borda
@tchaton @akihironitta @sailordiary @rohitgr7 @carmocca @elimohl @awaelchli @karthikprasad @sadiqj @mibaumgartner @BloodAxe @ethanwharris @THasthika
Weekly Patch Release v.1.2.7 [full merge, no squash] (#6850)
b2c7345 
* update readme by v1.2.x (#6728)

* [bugfix] Add support for omegaconf and tpu (#6741)

* fix_hydra

* update changelog

Co-authored-by: Your Name <you@example.com>

* [docs] Update Bolts link (#6743)

* Update Bolts link

* Update Bolts link

* formt

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>

* Update logic for checking TPUs availability (#6767)

* Update logic for checking TPUs availability

* fix flake8

* add fix

* resolve bug (#6781)

* Fix validation progress counter with check_val_every_n_epoch > 1 (#5952)

Co-authored-by: rohitgr7 <rohitgr1998@gmail.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

* Remove extinct parameters from lightning_module.rst (#6801)

Fixes  #6800

* Update TPU docs for installation (#6794)

* fix boolean check on iterable dataset when len not defined (#6828)

* fix iterable dataset len check

* update predict and validate

* add validate to test

* add changelog

* add predict

* Sanitize `None` params during pruning (#6836)

* sanitize none params during pruning

* amend

* Fix `unfreeze_and_add_param_group` expects `modules` rather than `module` (#6822)

* Enforce an epoch scheduler interval when using SWA (#6588)

Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>

* Fix DPP + SyncBN (#6838)

* Fix DPP + SyncBN

Ensure that model is already on correct GPU before applying SyncBN conversion

* Fix order of SyncBN for ddp_spawn

* [Fix] TPU Training Type Plugin (#6816)

* Fix support for symlink save_dir in TensorBoardLogger (#6730)

* Add test for symlink support and initial fix

* Respond to comment and add docstring

* Update CHANGELOG.md

* Simplify

* Update pytorch_lightning/utilities/cloud_io.py

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

* Make `LightningLocalFileSystem` protected

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

* Fixed missing arguments in `lr_find` call (#6784)

There seem to be 3 arguments missing in the `lr_find` call in the tunining.py file.

* Update Changelog & version

* Fix TPU tests for checkpoint

Skip advanced profiler for torch > 1.8

Skip pytorch profiler for torch > 1.8

Fix save checkpoint logic for TPUs

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: thomas chaton <thomas@grid.ai>
Co-authored-by: Your Name <you@example.com>
Co-authored-by: Akihiro Nitta <nitta@akihironitta.com>
Co-authored-by: Yuan-Hang Zhang <sailordiary@users.noreply.github.com>
Co-authored-by: rohitgr7 <rohitgr1998@gmail.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Elizaveta Logacheva <elimohl@gmail.com>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Co-authored-by: Karthik Prasad <prasadkr@uci.edu>
Co-authored-by: Sadiq Jaffer <sadiq@toao.com>
Co-authored-by: Michael Baumgartner <m.baumgartner@ymail.com>
Co-authored-by: Eugene Khvedchenya <ekhvedchenya@gmail.com>
Co-authored-by: Ethan Harris <ewah1g13@soton.ac.uk>
Co-authored-by: Tharindu Hasthika <tharindubathigama@gmail.com>
lexierule pushed a commit that referenced this pull request Apr 7, 2021
@THasthika @lexierule
Fixed missing arguments in lr_find call (#6784)
e6733ad 
There seem to be 3 arguments missing in the `lr_find` call in the tunining.py file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SkafteNicki SkafteNicki SkafteNicki approved these changes

@Borda Borda Borda approved these changes

@awaelchli awaelchli awaelchli approved these changes

Assignees
No one assigned
Labels
bug Something isn't working tuner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Trainer tuning fails when used with a LightningDataModule
5 participants
@THasthika @ananthsub @awaelchli @Borda @SkafteNicki