-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new receive flow #26148
feat: new receive flow #26148
Changes from 41 commits
906284f
6be8c00
8a21ffc
7c83dc7
15ddce1
f4cfdbd
aa2bcd3
c67492a
8df02d2
afbf1a7
ec0535c
e70e745
86dd4bb
dd2f20e
ba0dbc3
fde5c94
faf2a02
3763e6e
cdaae30
a9dfed9
f025cae
e65b814
d57a519
2ef88c7
14d7915
6f238e9
343bba6
75dde9e
40880c0
385793f
0020760
d5d6ba9
66c1421
0ec27fc
a008273
c459576
8b1b6da
1608274
c00bf73
ff6f902
57abcd1
e0bdf44
5ea0a07
0858533
75a7eae
3147f14
f1393da
36fc160
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,7 +7,6 @@ const { | |
regularDelayMs, | ||
largeDelayMs, | ||
completeImportSRPOnboardingFlow, | ||
completeImportSRPOnboardingFlowWordByWord, | ||
openActionMenuAndStartSendFlow, | ||
unlockWallet, | ||
logInWithBalanceValidation, | ||
|
@@ -61,7 +60,7 @@ describe('Import flow @no-mmi', function () { | |
await driver.clickElement( | ||
'[data-testid="account-list-item-menu-button"]', | ||
); | ||
await driver.clickElement('[data-testid="account-list-menu-details"'); | ||
await driver.clickElement('[data-testid="account-list-menu-details"]'); | ||
await driver.findVisibleElement('.qr-code__wrapper'); | ||
|
||
// shows a QR code for the account | ||
|
@@ -162,40 +161,6 @@ describe('Import flow @no-mmi', function () { | |
); | ||
}); | ||
|
||
it('Import wallet using Secret Recovery Phrase with pasting word by word', async function () { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why did we remove this test |
||
const testAddress = '0x0Cc5261AB8cE458dc977078A3623E2BaDD27afD3'; | ||
|
||
await withFixtures( | ||
{ | ||
fixtures: new FixtureBuilder({ onboarding: true }).build(), | ||
ganacheOptions, | ||
title: this.test.fullTitle(), | ||
}, | ||
async ({ driver }) => { | ||
await driver.navigate(); | ||
|
||
await completeImportSRPOnboardingFlowWordByWord( | ||
driver, | ||
TEST_SEED_PHRASE, | ||
WALLET_PASSWORD, | ||
); | ||
|
||
// Show account information | ||
await driver.clickElement('[data-testid="account-menu-icon"]'); | ||
await driver.clickElement( | ||
'[data-testid="account-list-item-menu-button"]', | ||
); | ||
await driver.clickElement('[data-testid="account-list-menu-details"'); | ||
await driver.findVisibleElement('.qr-code__wrapper'); | ||
// shows the correct account address | ||
await driver.findElement({ | ||
css: '.qr-code [data-testid="address-copy-button-text"]', | ||
text: testAddress, | ||
}); | ||
}, | ||
); | ||
}); | ||
|
||
it('Import Account using private key and remove imported account', async function () { | ||
const testPrivateKey1 = | ||
'14abe6f4aab7f9f626fe981c864d0adeb5685f289ac9270c27b8fd790b4235d6'; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this spec is called
has portfolio button enabled for BTC accounts
however, here we are checking if the receive button is enabled (not the portfolio).The portfolio link doesn't appear anymore. Is this expected? If so, the title for the test should be changed, otherwise we should open a bug, indicating that the portfolio link doesn't appear anymore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, PR to fix this:
#28184