Fix cloudflare redirects #2180
Merged
Fix cloudflare redirects #2180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrepimenta
added
needs-dev-review
ibrahimtaveras00
suggested changes
Jan 30, 2021
There was a problem hiding this comment.
When attempting to load axieinfinity.com on android browser, the app crashes; seen here = http://recordit.co/5hCtxzoqag
Nonetheless, I am able to access yfdai
ibrahimtaveras00
added
QA'd - Issues Found
Closed
|
@ibrahimtaveras00, regarding the first issue, I think this is also happening on older versions so I don't think it's related to this change. Does this also happen on a real device? |
|
I can't reproduce axie infinity issue on current playstore nor on this branch on a real device (tried on pixel 2 running OS 11 and Samsung Note 9 running OS 10 |
ibrahimtaveras00
added
QA Passed
rickycodes
approved these changes
Feb 4, 2021
rickycodes
added a commit
that referenced
this pull request
Feb 25, 2021
* develop: (48 commits) Fix input state (#2265) bump android versionCode (#2260) bugfix/use bignumber for transfer deeplinks (#2257) Fix account list scroll (#2256) TransactionController from controllers (#2243) Fix circleci apk (#2240) v1.0.11 (#2238) Feature/warn when replacing (#2176) contract metadata images bump (#2233) Handle `balanceError` case (#2148) Remove best deals badge from WYRE transfers. (#2228) @metamask/controllers@6.0.1 (#2217) Fix cloudflare redirects (#2180) Merge pull request from GHSA-wmvx-96jh-gcr4 Update @metamask/contract-metadata (#2203) React Native update to 0.63 (#2078) Create dependabot.yml (#2204) Fix "Text strings must be rendered within a <Text> component" (#2193) Use navigate instead of push (#2191) Add fiat on ramp modal close button extra hit area (#2174) ...
rickycodes
pushed a commit
that referenced
this pull request
Jan 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes cloudflare redirects on Android. Couldn't reproduce it on iOS.
Issue
Resolves #2170