Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix account list scroll #2256

Merged
merged 1 commit into from
Feb 17, 2021
Merged

Fix account list scroll #2256

merged 1 commit into from
Feb 17, 2021

Conversation

andrepimenta
Copy link
Member

@andrepimenta andrepimenta commented Feb 17, 2021 •
edited
Loading

Description

This PR fixes the account list scroll by making sure the list gets the panResponder priority so the user can scroll.

Issue

Resolves #2255

@andrepimenta andrepimenta requested a review from a team as a code owner February 17, 2021 13:58
@andrepimenta andrepimenta added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Feb 17, 2021
estebanmino
estebanmino approved these changes Feb 17, 2021
View reviewed changes
Copy link
Contributor

@estebanmino estebanmino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

ibrahimtaveras00
ibrahimtaveras00 approved these changes Feb 17, 2021
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to scroll to an account that had funds at the very top of the list and scroll down as well without any issues

Screen Shot 2021-02-17 at 12 55 21 PM

QA Passed 👍🏽

@ibrahimtaveras00 ibrahimtaveras00 added QA Passed A successful QA run through has been done next release and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Feb 17, 2021
@andrepimenta andrepimenta merged commit e310929 into develop Feb 17, 2021
@andrepimenta andrepimenta deleted the fix/account-list-scroll branch February 17, 2021 18:43
rickycodes added a commit that referenced this pull request Feb 25, 2021
@rickycodes
Merge branch 'develop' into storage-migration-update
2c390bc 
* develop: (48 commits)
  Fix input state (#2265)
  bump android versionCode (#2260)
  bugfix/use bignumber for transfer deeplinks (#2257)
  Fix account list scroll (#2256)
  TransactionController from controllers (#2243)
  Fix circleci apk (#2240)
  v1.0.11 (#2238)
  Feature/warn when replacing (#2176)
  contract metadata images bump (#2233)
  Handle `balanceError` case (#2148)
  Remove best deals badge from WYRE transfers. (#2228)
  @metamask/controllers@6.0.1 (#2217)
  Fix cloudflare redirects (#2180)
  Merge pull request from GHSA-wmvx-96jh-gcr4
  Update @metamask/contract-metadata (#2203)
  React Native update to 0.63 (#2078)
  Create dependabot.yml (#2204)
  Fix "Text strings must be rendered within a <Text> component" (#2193)
  Use navigate instead of push (#2191)
  Add fiat on ramp modal close button extra hit area (#2174)
  ...
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
@andrepimenta
Fix account list scroll (#2256)
a0375b3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estebanmino estebanmino estebanmino approved these changes

@ibrahimtaveras00 ibrahimtaveras00 ibrahimtaveras00 approved these changes

Assignees
No one assigned
Labels
next release QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't scroll on long list for "From" address on confirm view
3 participants
@andrepimenta @estebanmino @ibrahimtaveras00