Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use navigate instead of push #2191

Merged
merged 1 commit into from
Jan 29, 2021
Merged

Use navigate instead of push #2191

merged 1 commit into from
Jan 29, 2021

Conversation

rickycodes
Copy link
Member

@rickycodes rickycodes commented Jan 29, 2021 •
edited
Loading

Description

Instead of #2122 I realised we should just be using .navigate instead of .push

If you run this code, you'll notice that when you tap "Go to Details... again" that it doesn't do anything! This is because we are already on the Details route. The navigate function roughly means "go to this screen", and if you are already on that screen then it makes sense that it would do nothing.

there's likely a few other spots where we could make this same improvement

@rickycodes rickycodes requested a review from a team as a code owner January 29, 2021 19:38
@rickycodes rickycodes mentioned this pull request Jan 29, 2021
Closed
1 task
@rickycodes rickycodes added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Jan 29, 2021
ibrahimtaveras00
ibrahimtaveras00 approved these changes Jan 29, 2021
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Passed 👍🏽

@ibrahimtaveras00 ibrahimtaveras00 added QA Passed A successful QA run through has been done and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Jan 29, 2021
@rickycodes rickycodes merged commit 37fe224 into develop Jan 29, 2021
@rickycodes rickycodes deleted the feature/prevent-doubleclick branch January 29, 2021 19:59
rickycodes added a commit that referenced this pull request Feb 25, 2021
@rickycodes
Merge branch 'develop' into storage-migration-update
2c390bc 
* develop: (48 commits)
  Fix input state (#2265)
  bump android versionCode (#2260)
  bugfix/use bignumber for transfer deeplinks (#2257)
  Fix account list scroll (#2256)
  TransactionController from controllers (#2243)
  Fix circleci apk (#2240)
  v1.0.11 (#2238)
  Feature/warn when replacing (#2176)
  contract metadata images bump (#2233)
  Handle `balanceError` case (#2148)
  Remove best deals badge from WYRE transfers. (#2228)
  @metamask/controllers@6.0.1 (#2217)
  Fix cloudflare redirects (#2180)
  Merge pull request from GHSA-wmvx-96jh-gcr4
  Update @metamask/contract-metadata (#2203)
  React Native update to 0.63 (#2078)
  Create dependabot.yml (#2204)
  Fix "Text strings must be rendered within a <Text> component" (#2193)
  Use navigate instead of push (#2191)
  Add fiat on ramp modal close button extra hit area (#2174)
  ...
rickycodes added a commit that referenced this pull request Jan 31, 2022
@rickycodes
Use navigate instead of push (#2191)
45b9717
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibrahimtaveras00 ibrahimtaveras00 ibrahimtaveras00 approved these changes

Assignees
No one assigned
Labels
QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rickycodes @ibrahimtaveras00