Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update no select following review #1

Merged
merged 150 commits into from
Oct 2, 2024
Merged

Update no select following review #1

merged 150 commits into from
Oct 2, 2024

Conversation

MialLewis
Copy link
Owner

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

MialLewis and others added 30 commits July 31, 2024 15:21
@MialLewis
disable data selection from results table
a15cc8c
@MialLewis
disable selection from chart table
2a58dd7
@MialLewis
disable pivot chart select
62f5b00
@MialLewis
add user select to permissions model
ca17002
@MialLewis
change perms to can_export_csv
06a44d8
@MialLewis
pass dataSelectionMode prop to plugin
71018c8
@MialLewis
remove unneeded prop
703e7ef
@MialLewis
get permissions from role TableChart
fafe95b
@MialLewis
add user permissions to pivot table
27d22d1
@MialLewis
apply linter and fix compiler errors
6b35723
@MialLewis
update permissions to inline with previous features
6156e5f
@MialLewis
fix filterable table test
4b16a68
@bcook-konza
Merge pull request #1 from MialLewis/disable_data_selection_konza
1f7ff0e 
Disable data selection
@kgabryje
fix: Disable cross filtering on charts with no dimensions (apache#30176)
3aafd29
@dependabot
build(deps): bump @types/node from 20.12.7 to 22.5.4 in /superset-fro…
05197db 
…ntend (apache#30166)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@betodealmeida
feat: is_mutating method (apache#30177)
1f89071
@dependabot
build(deps): bump antd from 5.20.0 to 5.20.5 in /docs (apache#30179)
d685497 
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
build(deps-dev): bump webpack from 5.93.0 to 5.94.0 in /docs (apache#…
0080374 
…30036)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
build(deps-dev): bump @types/react from 18.3.3 to 18.3.5 in /docs (ap…
100b31c 
…ache#30101)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@rusackas
chore(docs): Removing dead link from INTHEWILD.md (apache#30199)
ff5cc09
@dependabot @rusackas
build(deps-dev): update @babel/types requirement from ^7.25.2 to ^7.2…
fed117f 
…5.6 in /superset-frontend/plugins/plugin-chart-pivot-table (apache#30103)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Evan Rusackas <evan@rusackas.com>
@mistercrunch @villebro
fix: set default mysql isolation level to 'READ COMMITTED' (apache#30174
6baeb65 
)

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
@geido
fix(Embedded): Dashboard screenshot should use GuestUser (apache#30200)
52a03f1
@betodealmeida
chore: remove duplicate _process_sql_expression (apache#30213)
cddf153
@Vitor-Avila
fix(Dashboard download): Download dashboard screenshot/PDF using Supe…
d191e67 
…rsetClient (apache#30212)
@hainenber
fix(sdk): use latest @supserset-ui/switchboard version to avoid pulli…
dd4f223 
…ng empty dependency (apache#30217)

Signed-off-by: hainenber <dotronghai96@gmail.com>
@jsoref @geido @rusackas
chore(frontend): Spelling (apache#25452)
d0c9cde 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Co-authored-by: Geido <60598000+geido@users.noreply.github.com>
Co-authored-by: Evan Rusackas <evan@preset.io>
@dependabot @rusackas
build(deps): update @babel/runtime requirement from ^7.1.2 to ^7.25.6…
5a0e887 
… in /superset-frontend/packages/superset-ui-core (apache#30091)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Evan Rusackas <evan@rusackas.com>
@rusackas
feat: Displaying details to Dataset/Database deletion modals (apache#…
7bb6a14 
…30016)
@dmarkey
feat(embedded): add hook to allow superset admins to validate guest t…
a31a4ee 
…oken parameters (apache#30132)

Co-authored-by: David Markey <markey@rapidraitngs.com>
dependabot bot and others added 29 commits October 1, 2024 11:47
@dependabot
build(deps): bump @docsearch/react from 3.6.1 to 3.6.2 in /docs (apac…
8a68a96 
…he#30483)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
build(deps-dev): bump @types/react from 18.3.5 to 18.3.10 in /docs (a…
7468904 
…pache#30481)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
build(deps-dev): bump webpack-manifest-plugin from 4.1.1 to 5.0.0 in …
ee9ece8 
…/superset-frontend (apache#30473)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
build(deps): bump re-resizable from 6.9.11 to 6.10.0 in /superset-fro…
a8500ab 
…ntend (apache#30477)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
build(deps-dev): bump @typescript-eslint/eslint-plugin from 8.6.0 to …
f425c9d 
…8.8.0 in /superset-websocket (apache#30464)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
build(deps-dev): bump @cypress/react from 5.12.5 to 8.0.2 in /superse…
e5ddb3b 
…t-frontend (apache#30459)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
build(deps-dev): bump eslint-plugin-file-progress from 1.4.0 to 1.5.0…
62350f2 
… in /superset-frontend (apache#30460)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
build(deps-dev): bump esbuild-loader from 4.1.0 to 4.2.2 in /superset…
15f3ea8 
…-frontend (apache#30487)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@hainenber
refactor(frontend): migrate 6 Enzyme-based tests to RTL, part 2 (apac…
da7a74e 
…he#30281)

Signed-off-by: hainenber <dotronghai96@gmail.com>
@dependabot
build(deps): bump debug from 4.3.6 to 4.3.7 in /superset-websocket/ut…
553932d 
…ils/client-ws-app (apache#30471)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
build(deps): bump @types/react-loadable from 5.5.6 to 5.5.11 in /supe…
7d0cb39 
…rset-frontend (apache#30469)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
build(deps): bump @types/prop-types from 15.7.5 to 15.7.13 in /supers…
d3a208e 
…et-frontend (apache#30467)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
build(deps-dev): bump @types/node from 22.0.2 to 22.7.4 in /superset-…
4c73b04 
…websocket (apache#30466)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
build(deps-dev): bump typescript-eslint from 8.6.0 to 8.8.0 in /super…
8019c8b 
…set-websocket (apache#30465)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
build(deps): bump @rjsf/core from 5.19.4 to 5.21.1 in /superset-front…
657377b 
…end (apache#30461)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
build(deps-dev): bump typescript from 5.5.4 to 5.6.2 in /docs (apache…
f409482 
…#30476)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@MialLewis
move access to redux state outside of filterable table comp
b7a785d
@MialLewis
move state query to DashboardBuilder
0ef5633
@MialLewis
revert redundant changes to filt table test
5d66273
@MialLewis
ammend transform props test
bb67c04
@MialLewis
remove unneeded import
fa24412
@MialLewis
access state from explorechartpanel
0df6fef
@MialLewis
correct chart props
45732ad
@MialLewis
remove canExportData from DashboardBuilder and component, pass in fro…
fef1e90 
…m gridConponents/chart
@MialLewis
run prettier
38215d2
@MialLewis
remove unneeded test change
7e2e1fa
@MialLewis
remove redundant filt table test var
8a31bf2
@MialLewis
update buildQuery test with DataSelectionMode
7d7f5f7
@MialLewis
Merge branch 'master' into update_no_select_following_review
aa02fc6
@MialLewis MialLewis merged commit d48533f into master Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.