Fix for short runs, correct indexing when last cluster has no spikes #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In postProcess and rezToPhy, allocate arrays to ensure summary measures are specified for highest index cluster even if it has no spikes.
Merged
cnuahs
pushed a commit
to cnuahs/Kilosort
that referenced
this pull request
Mar 9, 2024
Fix for short runs, correct indexing when last cluster has no spikes Former-commit-id: 7a2abf8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In runTemplates, don't save more PCs than time batchs
In postProcess and rezToPhy, allocate arrays to ensure summary measures are
specified for highest index cluster even if it has no spikes.
Important bug fix in mexmpnu8 -- skip conversion to/from doubles when ENSURE_DETERM compile switch is set.