Gathering GPU arrays to CPU before saving to .mat #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, the GPU arrays (e.g. `U` and `W`) are saved as garbage in the .mat file.
|
They load fine on computers with GPUs, but I agree it makes more sense to save them as CPU variables, thanks! |
|
Didn't know MATLAB handles that transparently; I've actually been introspecting the |
Merged
cnuahs
pushed a commit
to cnuahs/Kilosort
that referenced
this pull request
Mar 9, 2024
Gathering GPU arrays to CPU before saving to .mat Former-commit-id: bdf9366
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, the GPU arrays (e.g.
UandW) are saved as garbage inthe .mat file.
@marius10p ?