Feature 1796 places autocomplete #2314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robyngit
requested changes
Mar 21, 2024
There was a problem hiding this comment.
This is going to be fantastic @ianguerin, thanks for keeping it all so modular. I encountered some issues:
- When there's no maps key configured in a repository, the ToolbarView breaks and the help tab view doesn't get rendered. The console shows the message:
Error rendering ToolbarView section TypeError: gmaps is null - With a map key configured, I actually wasn't able to find any places. I only see the message: "No search results found."
I've hidden the viewfinder panel if there is not Google Maps API key now. |
ianguerin
force-pushed
the
feature-1796-places-autocomplete
branch
from
d6ba440
to
8186f78
Compare
|
Tested with a properly configured API key, it works so well!! 🎉🎉🎉 |
This logic will be removed from Viewfinder in future commit.
Add type safety checks.
Co-authored-by: Robyn <26600641+robyngit@users.noreply.github.com>
Include additional Google Maps API libraries on page. Create model services to interact with Google Maps APIs.
Co-authored-by: Robyn <26600641+robyngit@users.noreply.github.com>
Co-authored-by: Robyn <26600641+robyngit@users.noreply.github.com>
Co-authored-by: Robyn <26600641+robyngit@users.noreply.github.com>
Co-authored-by: Robyn <26600641+robyngit@users.noreply.github.com>
Co-authored-by: Robyn <26600641+robyngit@users.noreply.github.com>
Add ViewfinderModel which will be used by ViewfinderView in a later commit. Prediction models can be represented by a PredictionView which are in turn managed as an unordered list.
ianguerin
force-pushed
the
feature-1796-places-autocomplete
branch
from
c8c9199
to
7d77304
Compare
robyngit
requested changes
Mar 25, 2024
Co-authored-by: Robyn <26600641+robyngit@users.noreply.github.com>
Co-authored-by: Robyn <26600641+robyngit@users.noreply.github.com>
robyngit
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes all changes from individual PRs 1,2,3 and 5 (contents of 4 included in earlier PR) that were individually reviewed.
The goal of this PR is to be tested using a more manual review, by running in various themes.