Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature 1796 places autocomplete #2314

Merged
merged 30 commits into from
Mar 25, 2024
Merged

Feature 1796 places autocomplete #2314

merged 30 commits into from
Mar 25, 2024

Commits on Mar 22, 2024

  1. Move lat, long parsing and validations logic into GeoPoint 

    This logic will be removed from Viewfinder in future commit.
    @ianguerin
    ianguerin committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    dd28faf View commit details
    Browse the repository at this point in the history

  2. Fixup: Undefined checks for GeoPoint static functions

    @ianguerin
    ianguerin committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    e7d66ee View commit details
    Browse the repository at this point in the history

  3. Fixup: Migrate fromString static method to Backbone-style parse function 

    Add type safety checks.
    @ianguerin
    ianguerin committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    f5c4e6a View commit details
    Browse the repository at this point in the history

  4. Fixup: Parse always returns Backbone-expected value 

    Co-authored-by: Robyn <26600641+robyngit@users.noreply.github.com>
    @ianguerin @robyngit
    ianguerin and robyngit committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    d1344fd View commit details
    Browse the repository at this point in the history

  5. Use Google Maps API Autocomplete and Geocoder 

    Include additional Google Maps API libraries on page.
Create model services to interact with Google Maps APIs.
    @ianguerin
    ianguerin committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    b65bb9d View commit details
    Browse the repository at this point in the history

  6. Fixup: Hide Google Maps details from GeocoderSearch

    @ianguerin
    ianguerin committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    0c54e00 View commit details
    Browse the repository at this point in the history

  7. Fixup: Use es6 class for GeocoderSearch

    @ianguerin
    ianguerin committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    d28a553 View commit details
    Browse the repository at this point in the history

  8. Fixup: Add sinon earlier in PR chain to fix failing unit tests

    @ianguerin
    ianguerin committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    817db52 View commit details
    Browse the repository at this point in the history

  9. Fixup: Load mock gmaps module before loading any test code

    @ianguerin
    ianguerin committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    5a8053f View commit details
    Browse the repository at this point in the history

  10. Fixup: remove focus on single describe test block

    @ianguerin
    ianguerin committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    3296eae View commit details
    Browse the repository at this point in the history

  11. Fixup: Migrate geocoder models to es6 classes

    @ianguerin
    ianguerin committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    85b0d4d View commit details
    Browse the repository at this point in the history

  12. Fixup: Pass Prediction object to GoogleMapsGeocoder

    @ianguerin
    ianguerin committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    65fd724 View commit details
    Browse the repository at this point in the history

  13. Fixup: Add return types for JSDocs

    @ianguerin
    ianguerin committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    abe9666 View commit details
    Browse the repository at this point in the history

  14. Update src/js/models/geocoder/GeocodedLocation.js 

    Co-authored-by: Robyn <26600641+robyngit@users.noreply.github.com>
    @ianguerin @robyngit
    ianguerin and robyngit committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    2a9560e View commit details
    Browse the repository at this point in the history

  15. Update src/js/models/geocoder/GeocoderSearch.js 

    Co-authored-by: Robyn <26600641+robyngit@users.noreply.github.com>
    @ianguerin @robyngit
    ianguerin and robyngit committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    591eebc View commit details
    Browse the repository at this point in the history

  16. Update src/js/models/geocoder/GoogleMapsAutocompleter.js 

    Co-authored-by: Robyn <26600641+robyngit@users.noreply.github.com>
    @ianguerin @robyngit
    ianguerin and robyngit committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    71318e5 View commit details
    Browse the repository at this point in the history

  17. Update src/js/models/geocoder/GoogleMapsGeocoder.js 

    Co-authored-by: Robyn <26600641+robyngit@users.noreply.github.com>
    @ianguerin @robyngit
    ianguerin and robyngit committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    d9f7a67 View commit details
    Browse the repository at this point in the history

  18. Update src/js/models/geocoder/Prediction.js 

    Co-authored-by: Robyn <26600641+robyngit@users.noreply.github.com>
    @ianguerin @robyngit
    ianguerin and robyngit committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    2f384d6 View commit details
    Browse the repository at this point in the history

  19. Fixup: JSdoc comments and es6 class docs

    @ianguerin
    ianguerin committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    1d7f759 View commit details
    Browse the repository at this point in the history

  20. Create child views managing list of Predictions 

    Add ViewfinderModel which will be used by ViewfinderView in a later
commit.
Prediction models can be represented by a PredictionView which are in
turn managed as an unordered list.
    @ianguerin
    ianguerin committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    08838e3 View commit details
    Browse the repository at this point in the history

  21. Fixup: Move debounce logic out of ViewfinderModel

    @ianguerin
    ianguerin committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    6c9bc9b View commit details
    Browse the repository at this point in the history

  22. Move viewfinder related files into their own directory

    @ianguerin
    ianguerin committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    d3e15f3 View commit details
    Browse the repository at this point in the history

  23. Support places search in viewfinder view 

    Replace lat,long-only search with search for reqular query strings.

fixes #2280
fixes #2270
fixes #1796
    @ianguerin
    ianguerin committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    883aff0 View commit details
    Browse the repository at this point in the history

  24. Fixup: Simplify showing predictions list logic

    @ianguerin
    ianguerin committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    57b81d5 View commit details
    Browse the repository at this point in the history

  25. Fixup: Hide ViewfinderView if there is not Google Maps API key

    @ianguerin
    ianguerin committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    c054806 View commit details
    Browse the repository at this point in the history

  26. Fixup: Add comment explaining dependency on Google Maps API for Viewf… 

    …inderView
    @ianguerin
    ianguerin committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    6cd8c18 View commit details
    Browse the repository at this point in the history

  27. Fixup: Show error when Google Maps API key does not support Geocoding… 

    … or Places APIs
    @ianguerin
    ianguerin committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    7d77304 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2024

  1. Update src/js/models/geocoder/GoogleMapsAutocompleter.js 

    Co-authored-by: Robyn <26600641+robyngit@users.noreply.github.com>
    @ianguerin @robyngit
    ianguerin and robyngit authored Mar 25, 2024
    Configuration menu
    Copy the full SHA
    a2db923 View commit details
    Browse the repository at this point in the history

  2. Update src/js/models/maps/viewfinder/ViewfinderModel.js 

    Co-authored-by: Robyn <26600641+robyngit@users.noreply.github.com>
    @ianguerin @robyngit
    ianguerin and robyngit authored Mar 25, 2024
    Configuration menu
    Copy the full SHA
    e591e93 View commit details
    Browse the repository at this point in the history

  3. Fixup: Update error messages in tests

    @ianguerin
    ianguerin committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    e792a65 View commit details
    Browse the repository at this point in the history