-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable CMAQ scavenging and wet removal in resolved clouds #24
Enable CMAQ scavenging and wet removal in resolved clouds #24
Conversation
What is the difference between PRs#23 and #24? |
@JianpingHuang-NOAA I don't see a PR#23 |
A typo. It is issue 23# |
@rmontuoro It looks like baselines are changing, is this expected?
|
@BrianCurtis-NOAA - Yes. The AQM baseline (tracers) is expected to change since new physical processes are now enabled. |
@rmontuoro Do you mind if i merge in ytangnoaa's pt-source changes into this for getting 2 changes into UFSWM? |
@BrianCurtis-NOAA - I would like to review PR #18 before merging. |
@rmontuoro I will start testing with this PR w/o merging in AQM PR #18 at 2:00 if I don't hear back from you about reviewing AQM PR #18, and will work on AQM PR #18 tomorrow. |
@JianpingHuang-NOAA has asked me to hold on this PR as he talks with @rmontuoro about some issues. |
aqueous chemistry while keeping aqueous chemistry disabled.
@BrianCurtis-NOAA - The latest updates reproduce bit-per-bit the results from @JianpingHuang-NOAA's original changes in the |
Great, I may look to get this into tomorrow's UFSWM pr. As long as everything goes smoothly with the current UFSWM PR. |
… wet deposition processes in resolved-scale clouds.
@BrianCurtis-NOAA - PR #32 was merged into this PR. |
@bbakernoaa @JianpingHuang-NOAA Please provide a review of the code as we will merge this PR ASAP. |
# | ||
# - enable wet deposition processes in resolved-scale clouds | ||
# | ||
run_rescld: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like the option here
This PR enables CMAQ-provided simplistic scavenging and wet removal in resolved clouds to address issue #23.
A ufs-weather-model branch is available for testing purposes:
Note: This branch also includes changes to fv3atm enabling AOD output. A PR need to be created to merge such changes into the fv3atm develop branch.
Depends on NOAA-EMC/fv3atm/pull/593
Part of ufs-community/ufs-weather-model/pull/1456