Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable CMAQ scavenging and wet removal in resolved clouds #24

Merged
merged 15 commits into from
Nov 3, 2022

Conversation

rmontuoro
Copy link
Collaborator

@rmontuoro rmontuoro commented Oct 13, 2022

This PR enables CMAQ-provided simplistic scavenging and wet removal in resolved clouds to address issue #23.

A ufs-weather-model branch is available for testing purposes:

 git clone -b feature/aqm-rescld-wdep --recursive https://github.com/rmontuoro/ufs-weather-model

Note: This branch also includes changes to fv3atm enabling AOD output. A PR need to be created to merge such changes into the fv3atm develop branch.

Depends on NOAA-EMC/fv3atm/pull/593
Part of ufs-community/ufs-weather-model/pull/1456

@JianpingHuang-NOAA
Copy link
Collaborator

What is the difference between PRs#23 and #24?

@bbakernoaa
Copy link
Contributor

@JianpingHuang-NOAA I don't see a PR#23

@JianpingHuang-NOAA
Copy link
Collaborator

A typo. It is issue 23#

@BrianCurtis-NOAA
Copy link
Collaborator

@rmontuoro It looks like baselines are changing, is this expected?

baseline dir = /scratch1/NCEPDEV/nems/emc.nemspara/RT/NEMSfv3gfs/develop-20221007/INTEL/regional_atmaq
working dir  = /scratch1/NCEPDEV/stmp2/Brian.Curtis/FV3_RT/rt_11339/regional_atmaq
Checking test 001 regional_atmaq results ....
 Comparing sfcf000.nc ............ALT CHECK......NOT OK
 Comparing sfcf003.nc ............ALT CHECK......NOT OK
 Comparing sfcf006.nc ............ALT CHECK......NOT OK
 Comparing atmf000.nc ............ALT CHECK......NOT OK
 Comparing atmf003.nc ............ALT CHECK......NOT OK
 Comparing atmf006.nc ............ALT CHECK......NOT OK
 Comparing RESTART/coupler.res .........OK
 Comparing RESTART/fv_core.res.nc .........OK
 Comparing RESTART/fv_core.res.tile1.nc .........OK
 Comparing RESTART/fv_srf_wnd.res.tile1.nc .........OK
 Comparing RESTART/fv_tracer.res.tile1.nc ............ALT CHECK......NOT OK
 Comparing RESTART/phy_data.nc .........OK
 Comparing RESTART/sfc_data.nc .........OK

@rmontuoro
Copy link
Collaborator Author

@BrianCurtis-NOAA - Yes. The AQM baseline (tracers) is expected to change since new physical processes are now enabled.

@BrianCurtis-NOAA
Copy link
Collaborator

@rmontuoro Do you mind if i merge in ytangnoaa's pt-source changes into this for getting 2 changes into UFSWM?

@rmontuoro
Copy link
Collaborator Author

@BrianCurtis-NOAA - I would like to review PR #18 before merging.

@BrianCurtis-NOAA
Copy link
Collaborator

@BrianCurtis-NOAA - I would like to review PR #18 before merging.

@rmontuoro I will start testing with this PR w/o merging in AQM PR #18 at 2:00 if I don't hear back from you about reviewing AQM PR #18, and will work on AQM PR #18 tomorrow.

@BrianCurtis-NOAA
Copy link
Collaborator

@JianpingHuang-NOAA has asked me to hold on this PR as he talks with @rmontuoro about some issues.

@rmontuoro
Copy link
Collaborator Author

@BrianCurtis-NOAA - The latest updates reproduce bit-per-bit the results from @JianpingHuang-NOAA's original changes in the regional_atmaq regression test.

@BrianCurtis-NOAA
Copy link
Collaborator

Great, I may look to get this into tomorrow's UFSWM pr. As long as everything goes smoothly with the current UFSWM PR.

@rmontuoro
Copy link
Collaborator Author

@BrianCurtis-NOAA - PR #32 was merged into this PR.

@BrianCurtis-NOAA
Copy link
Collaborator

@bbakernoaa @JianpingHuang-NOAA Please provide a review of the code as we will merge this PR ASAP.

#
# - enable wet deposition processes in resolved-scale clouds
#
run_rescld: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like the option here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants