-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AQM] [FV3] [WW3] Enable CMAQ scavenging and wet removal in resolved clouds, ESMF 8.4 support for AQM, Update WW3. #1456
[AQM] [FV3] [WW3] Enable CMAQ scavenging and wet removal in resolved clouds, ESMF 8.4 support for AQM, Update WW3. #1456
Conversation
Baselines are changing and it's expected, but only for regional_atmaq
|
Hera.intel for atmaq testing for reproducability with new baseline:
|
…r-model into feature/aqm-rescld-wdep
Jenkins-ci run logs attached. |
Automated RT Failure Notification |
Ignore the Acorn log for now. Pushed the module updates for acorn based on discussion in code managers channel. |
on-behalf-of @ufs-community <brian.curtis@noaa.gov>
on-behalf-of @ufs-community <brian.curtis@noaa.gov>
on-behalf-of @ufs-community <brian.curtis@noaa.gov>
on-behalf-of @ufs-community <brian.curtis@noaa.gov>
on-behalf-of @ufs-community <brian.curtis@noaa.gov>
on-behalf-of @ufs-community <brian.curtis@noaa.gov>
Automated RT Failure Notification |
on-behalf-of @ufs-community <brian.curtis@noaa.gov>
…too high for Acorn
…/ufs-weather-model into feature/aqm-rescld-wdep
@jkbk2004 lets merge in the AM, any update on Orion? |
@BrianCurtis-NOAA Orion is back now. No problem to merge first thing tomorrow morning. |
@BrianCurtis-NOAA I am moving to fv3atm pr 593 to ask merge there. |
@BrianCurtis-NOAA the fv3atm pr was merged. With the hash update, we can merge in this pr, |
PR Checklist
This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.
This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR
An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
are specified below.
Results for one or more of the regression tests change and the reasons for the changes are understood and explained below.
New or updated input data is required by this PR. If checked, please work with the code managers to update input data sets on all platforms.
Description
This PR enables CMAQ-provided simplistic scavenging and wet removal in resolved clouds
Issue(s) addressed
Fixes NOAA-EMC/AQM/issues/23
Fixes #1473
Fixes NOAA-EMC/AQM/issues/5
Additional PR's closed (merged)
Closes: #1474 (WW3 update)
Closes: #1476 (AQM ESMF 8.4 support))
Testing
How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)
Dependencies
Depends on: NOAA-EMC/AQM/pull/24
Depends on: NOAA-EMC/fv3atm/pull/593
Depends on: NOAA-EMC/WW3/pull/840