-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable AOD in AQM #593
Merged
Merged
Enable AOD in AQM #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will start testing in UFSWM shortly. It's a small change that shouldn't impact anything other than AQM, please let me know if you feel otherwise before I get too far into testing. |
@rmontuoro Could you please merge in the latest updates from NOAA-EMC/fv3atm develop branch? |
@BrianCurtis-NOAA - done. |
DusanJovic-NOAA
approved these changes
Oct 24, 2022
We're ready for reviews / merge on the UFSWM side. |
@DusanJovic-NOAA please add a second reviewer. |
DusanJovic-NOAA
approved these changes
Nov 3, 2022
jkbk2004
approved these changes
Nov 3, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These changes will allow AOD with the AQM.
Issue(s) addressed
Addresses NOAA-EMC/AQM/issues/23
Testing
How were these changes tested? Intel/Hera
Are the changes covered by regression tests? Not yet, not needed.
Have the ufs-weather-model regression test been run? On what platform?
Dependencies
None