Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable AOD in AQM #593

Merged
merged 4 commits into from
Nov 3, 2022
Merged

Conversation

BrianCurtis-NOAA
Copy link
Collaborator

Description

These changes will allow AOD with the AQM.

Issue(s) addressed

Addresses NOAA-EMC/AQM/issues/23

Testing

How were these changes tested? Intel/Hera
Are the changes covered by regression tests? Not yet, not needed.
Have the ufs-weather-model regression test been run? On what platform?

  • Will the code updates change regression test baseline? No

Dependencies

None

@BrianCurtis-NOAA
Copy link
Collaborator Author

This will start testing in UFSWM shortly. It's a small change that shouldn't impact anything other than AQM, please let me know if you feel otherwise before I get too far into testing.

@BrianCurtis-NOAA
Copy link
Collaborator Author

@rmontuoro Could you please merge in the latest updates from NOAA-EMC/fv3atm develop branch?

@rmontuoro
Copy link
Collaborator

@BrianCurtis-NOAA - done.

@BrianCurtis-NOAA
Copy link
Collaborator Author

We're ready for reviews / merge on the UFSWM side.

@BrianCurtis-NOAA
Copy link
Collaborator Author

@DusanJovic-NOAA please add a second reviewer.

@jkbk2004 jkbk2004 self-requested a review November 3, 2022 14:28
@jkbk2004 jkbk2004 merged commit 045de83 into NOAA-EMC:develop Nov 3, 2022
@grantfirl grantfirl mentioned this pull request Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants