Implement the capability to process chemical model NETCDF output and UFS-Aerosols model output #561
Conversation
… both GEFS-Aerosols (gocart_on) and UFS-Aerosols (nasa_on).
|
@zhanglikate Can you provide me model history files for testing new aerosol products? Thanks! |
@WenMeng-NOAA You can find the netcdf output with chemical fields at: /scratch2/NCEPDEV/naqfc/Kate.Zhang/fv3gfs/comrot/NP8C_C96_ATM/gfs.20160715-nofb/00/atmos Thanks. |
|
@zhanglikate My test is at /scratch1/NCEPDEV/stmp2/Wen.Meng/post_gfs_2016071500. Can you verify if it is consistent with your test? |
|
@zhanglikate My test is at /scratch1/NCEPDEV/stmp2/Wen.Meng/post_gfs_2016071500. Can you verify if it is consistent with your test? |
I am wondering how can I compare it? This is my test: /scratch1/NCEPDEV/stmp2/Kate.Zhang/post_gfs_2016071500 |
@zhanglikate It looks the master file from UPP were not archived in your test. Can you take a look at the mast file from my test GFSPRS.GrbF12 if all expected variables (postcntrl_ufs_aerosol.xml) are there? |
|
@WenMeng-NOAA How can I check the file of GFSPRS.GrbF12 ? Which tool that I can use to check it? Thanks. Or any way that I can archived the master file in my test? |
@zhanglikate The GFSPRS.GrbF12 is grib2 file generated in UPP with your UPP control file postcntrl_ufs_aerosol.xml. You might use wgrib2 to dump it. |
@WenMeng-NOAA What is the resolution? 0.25, 0.5 or 1? |
@WenMeng-NOAA I have the master output at: /scratch1/NCEPDEV/stmp2/Kate.Zhang/gfs.2016071500 , I just converted them to Netcdf and compared with your results, for the chemical related fields, they are identical. Thanks. |
…gfs_atmos_nceppost.sh) Clean the unused dust variables in FDLVL.f and MDL2P.f
|
@zhanglikate is there any reason for this revert (3f43201) ? |
@lipan-NOAA I suggested @zhanglikate to revert the changes because these two scripts are used for GFS post processing only. The changes could be added when the benchmarks for GFS V17 or GEFS V13 implementations are started. |
sorc/ncep_post.fd/CLDRAD.f
Outdated
| @@ -5490,6 +5377,43 @@ SUBROUTINE CLDRAD | |||
| datapd(1:iend-ista+1,1:jend-jsta+1,cfld)=GRID1(ista:iend,jsta:jend) | |||
| endif | |||
| ENDIF | |||
| #if 0 | |||
There was a problem hiding this comment.
@zhanglikate May I ask for the intention of the line "#if 0" and "endif"?
There was a problem hiding this comment.
It means that the parts between "#if 0" and "#endif" are commented out.
There was a problem hiding this comment.
@zhanglikate I saw the warning message from compiling as:
/home/Wen.Meng/stmp2/kate/UPP/sorc/ncep_post.fd/CLDRAD.f(5380): warning #5117: Bad # preprocessor line
#if 0
-^
/home/Wen.Meng/stmp2/kate/UPP/sorc/ncep_post.fd/CLDRAD.f(5415): warning #5117: Bad # preprocessor line
#endif
The block is new code for outputting two new variables. You commented it out temporarily?
|
Yes. I think we have to cancel the part by commenting out now. Thanks. |
|
@zhanglikate Can you add change logs with your name at the beginning section of all fortran files you modified? |
sorc/ncep_post.fd/FDLVL.f
Outdated
| @@ -812,6 +789,7 @@ SUBROUTINE FDLVL_UV(ITYPE,NFD,HTFD,UFD,VFD) | |||
| !> 2017-06-01 | Y Mao | Add FD levels for GTG(EDPARM CATEDR MWTURB) and allow levels input from control file | |||
| !> 2019-09-25 | Y Mao | Seperate mass from UV allow array of mass input to interpolate multiple fields with the same levels at one time. Dust=> AERFD can be processed when NIN=NBIN_DU | |||
| !> 2020-11-10 | Jesse Meng | Use UPP_PHYSICS module | |||
| !> 2022-09-22 | Li(Kate) Zhang | Remove Dust=> AERFD | |||
There was a problem hiding this comment.
@zhanglikate Should this change log be moved to after line 4?
There was a problem hiding this comment.
@WenMeng-NOAA Which line 4?
There was a problem hiding this comment.
@zhanglikate Sorry for typo. Line 41.
sorc/ncep_post.fd/MDL2P.f
Outdated
| IF(DUST(I,J,1,K) < SPVAL) DUSTSL(I,J,K) = DUST(I,J,1,K) | ||
| ENDDO | ||
| endif | ||
| ! if (gocart_on) then |
There was a problem hiding this comment.
@zhanglikate Since these are legacy code, could they be deleted instead of commented out?
There was a problem hiding this comment.
@WenMeng-NOAA Removed. Thanks.
| @@ -2062,130 +2061,7 @@ SUBROUTINE MDL2P(iostatusD3D) | |||
| endif | |||
| ENDIF | |||
| ENDIF | |||
| if (gocart_on) then | |||
There was a problem hiding this comment.
@zhanglikate Since the output of UPP ID 439 to 442 in this routine, could you update post_avblflds.xml for removing their definitions?
There was a problem hiding this comment.
@WenMeng-NOAA Removed. Thanks.
2. Re-assign the 6 AOD from GFS from 600-605 (rdaod). 3. Update the look-up table for UFS-Aerosols (nasa_on).
|
@zhanglikate did you update the NASA lookup tables using Sarah's code ? |
|
@lipan-NOAA Yes. I am using the code you sent to me to update it, which I think it is from Sarah. |
WenMeng-NOAA
added
GFSV17
No Baseline Change
|
The UPP RT tests were completed on WCOSS2, Hera and Orion. No baseline updates are needed with this PR. |
|
@lipan-NOAA, @JianpingHuang-NOAA and @AnningCheng-NOAA Please let me know if any unexpected results are found from your testing for GEFS aerosol, AQM, and GFSV17 MERRA aerosol. Thanks! |
|
@WenMeng-NOAA Could you point me the directory of your test on WCOSS2 ? |
@lipan-NOAA Please see on cactus:
The two tests use the same model history files provided from you. Thanks! |
|
The modifications related to MERRA2 (rdaod=T) looks fine and passed my tests. Approved. |
The previous UPP can only process the NEMSIO format for chemical output of GEFS-Aerosols. The updates has implemented the capability to read the chemical model NETCDF output for both GEFS-Aerosols (by turning on gocart_on) and UFS-Aerosols (by turning on nasa_on).
Also, re-assign the 6 AOD from GFS from 600-605 (rdaod) and Update the look-up table for UFS-Aerosols (nasa_on).